Title: [243490] trunk/Source/WebKit
- Revision
- 243490
- Author
- commit-qu...@webkit.org
- Date
- 2019-03-26 03:16:46 -0700 (Tue, 26 Mar 2019)
Log Message
[GTK][WPE] Disable process warming
https://bugs.webkit.org/show_bug.cgi?id=196208
Patch by Patrick Griffis <pgrif...@igalia.com> on 2019-03-26
Reviewed by Chris Dumez.
Fixes crash caused by r243384.
Process warming is incompatible with our launcher as it expects a valid
WebsiteDataStore at initialization time for sandbox permissions.
* UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::platformInitialize):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (243489 => 243490)
--- trunk/Source/WebKit/ChangeLog 2019-03-26 09:34:07 UTC (rev 243489)
+++ trunk/Source/WebKit/ChangeLog 2019-03-26 10:16:46 UTC (rev 243490)
@@ -1,3 +1,18 @@
+2019-03-26 Patrick Griffis <pgrif...@igalia.com>
+
+ [GTK][WPE] Disable process warming
+ https://bugs.webkit.org/show_bug.cgi?id=196208
+
+ Reviewed by Chris Dumez.
+
+ Fixes crash caused by r243384.
+
+ Process warming is incompatible with our launcher as it expects a valid
+ WebsiteDataStore at initialization time for sandbox permissions.
+
+ * UIProcess/glib/WebProcessPoolGLib.cpp:
+ (WebKit::WebProcessPool::platformInitialize):
+
2019-03-25 Alex Christensen <achristen...@webkit.org>
Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
Modified: trunk/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp (243489 => 243490)
--- trunk/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp 2019-03-26 09:34:07 UTC (rev 243489)
+++ trunk/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp 2019-03-26 10:16:46 UTC (rev 243490)
@@ -86,6 +86,13 @@
if (!memoryPressureMonitorDisabled())
installMemoryPressureHandler();
+
+ // Process warming is incompatible with the fact our WebProcessProxy::platformGetLaunchOptions()
+ // requires a valid WebsiteDataStore at initialization time for our sandbox permissions.
+ // FIXME: With process warming disabled, the performance of
+ // process-swap-on-navigation is not going to be great. So this needs to be
+ // re-enabled when we enable PSON.
+ configuration().setIsAutomaticProcessWarmingEnabled(false);
}
void WebProcessPool::platformInitializeWebProcess(WebProcessCreationParameters& parameters)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
