Title: [243921] trunk/Websites/bugs.webkit.org
- Revision
- 243921
- Author
- aakash_j...@apple.com
- Date
- 2019-04-04 17:31:41 -0700 (Thu, 04 Apr 2019)
Log Message
Add another status-bubble iframe to display results from new EWS
https://bugs.webkit.org/show_bug.cgi?id=196308
Reviewed by Lucas Forschler.
* js/status-bubble.js:
(handleStatusBubbleMessage): Added URL for new EWS.
(handleStatusBubbleLoadNewEWS): Method to post message to new EWS.
* code-review.js: Added another iframe to display results from new EWS.
* template/en/default/attachment/edit.html.tmpl: Ditto.
* template/en/default/attachment/list.html.tmpl: Ditto.
* template/en/default/attachment/reviewform.html.tmpl: Ditto.
Modified Paths
Diff
Modified: trunk/Websites/bugs.webkit.org/ChangeLog (243920 => 243921)
--- trunk/Websites/bugs.webkit.org/ChangeLog 2019-04-05 00:28:21 UTC (rev 243920)
+++ trunk/Websites/bugs.webkit.org/ChangeLog 2019-04-05 00:31:41 UTC (rev 243921)
@@ -1,3 +1,18 @@
+2019-04-04 Aakash Jain <aakash_j...@apple.com>
+
+ Add another status-bubble iframe to display results from new EWS
+ https://bugs.webkit.org/show_bug.cgi?id=196308
+
+ Reviewed by Lucas Forschler.
+
+ * js/status-bubble.js:
+ (handleStatusBubbleMessage): Added URL for new EWS.
+ (handleStatusBubbleLoadNewEWS): Method to post message to new EWS.
+ * code-review.js: Added another iframe to display results from new EWS.
+ * template/en/default/attachment/edit.html.tmpl: Ditto.
+ * template/en/default/attachment/list.html.tmpl: Ditto.
+ * template/en/default/attachment/reviewform.html.tmpl: Ditto.
+
2019-01-18 Ling Ho <lin...@apple.com>
Update Bugzilla running on bugs.webkit.org and bugs.webkit-uat.org to version 5.0.4
Modified: trunk/Websites/bugs.webkit.org/code-review.js (243920 => 243921)
--- trunk/Websites/bugs.webkit.org/code-review.js 2019-04-05 00:28:21 UTC (rev 243920)
+++ trunk/Websites/bugs.webkit.org/code-review.js 2019-04-05 00:31:41 UTC (rev 243921)
@@ -1,4 +1,5 @@
// Copyright (C) 2010 Adam Barth. All rights reserved.
+// Copyright (C) 2019 Apple Inc. All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are met:
@@ -573,6 +574,12 @@
statusBubble._onload_ = function () { handleStatusBubbleLoad(this); };
$('.statusBubble').append(statusBubble);
+ var statusBubbleNewEWS = document.createElement('iframe');
+ statusBubbleNewEWS.src = '' + attachment_id + '/';
+ // Can't append the HTML because we need to set the onload handler before appending the iframe to the DOM.
+ statusBubbleNewEWS._onload_ = function () { handleStatusBubbleLoadNewEWS(this); };
+ $('.statusBubble').append(statusBubbleNewEWS);
+
$('#toolbar .bugLink').html('<a href="" + bug_id + '" target="_blank">Bug ' + bug_id + '</a>');
});
}
Modified: trunk/Websites/bugs.webkit.org/js/status-bubble.js (243920 => 243921)
--- trunk/Websites/bugs.webkit.org/js/status-bubble.js 2019-04-05 00:28:21 UTC (rev 243920)
+++ trunk/Websites/bugs.webkit.org/js/status-bubble.js 2019-04-05 00:31:41 UTC (rev 243921)
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2018 Sony Interactive Entertainment Inc.
+ * Copyright (C) 2019 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -24,7 +25,7 @@
*/
function handleStatusBubbleMessage(event) {
- if (event.origin !== 'https://webkit-queues.webkit.org' || !event.data.height)
+ if ((event.origin !== 'https://webkit-queues.webkit.org' && event.origin !== 'https://ews.webkit.org') || !event.data.height)
return;
for (const iframe of document.querySelectorAll('.statusBubble > iframe')) {
@@ -39,3 +40,7 @@
function handleStatusBubbleLoad(iframe) {
iframe.contentWindow.postMessage('containerMetrics', 'https://webkit-queues.webkit.org');
}
+
+function handleStatusBubbleLoadNewEWS(iframe) {
+ iframe.contentWindow.postMessage('containerMetrics', 'https://ews.webkit.org');
+}
Modified: trunk/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl (243920 => 243921)
--- trunk/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl 2019-04-05 00:28:21 UTC (rev 243920)
+++ trunk/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl 2019-04-05 00:31:41 UTC (rev 243921)
@@ -265,8 +265,11 @@
<div class="statusBubble">
<iframe src="" attachment.id %]"
- style="width: 600px; height: 20px; border: none;" scrolling="no" _onload_="handleStatusBubbleLoad(this)">
+ style="width: 0px; height: 20px; border: none;" scrolling="no" _onload_="handleStatusBubbleLoad(this)">
</iframe>
+ <iframe src="" attachment.id %]/"
+ style="width: 0px; height: 20px; border: none;" scrolling="no" _onload_="handleStatusBubbleLoadNewEWS(this)">
+ </iframe>
</div>
<br>
[% END %]
Modified: trunk/Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl (243920 => 243921)
--- trunk/Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl 2019-04-05 00:28:21 UTC (rev 243920)
+++ trunk/Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl 2019-04-05 00:31:41 UTC (rev 243921)
@@ -156,8 +156,11 @@
[% IF attachment.ispatch %]
<div class="statusBubble">
<iframe src="" attachment.id %]"
- style="width: 600px; height: 20px; border: none;" scrolling="no" _onload_="handleStatusBubbleLoad(this)">
+ style="width: 0px; height: 20px; border: none;" scrolling="no" _onload_="handleStatusBubbleLoad(this)">
</iframe>
+ <iframe src="" attachment.id %]/"
+ style="width: 0px; height: 20px; border: none;" scrolling="no" _onload_="handleStatusBubbleLoadNewEWS(this)">
+ </iframe>
</div>
[% END %]
[%# endif // WEBKIT_CHANGES %]
Modified: trunk/Websites/bugs.webkit.org/template/en/default/attachment/reviewform.html.tmpl (243920 => 243921)
--- trunk/Websites/bugs.webkit.org/template/en/default/attachment/reviewform.html.tmpl 2019-04-05 00:28:21 UTC (rev 243920)
+++ trunk/Websites/bugs.webkit.org/template/en/default/attachment/reviewform.html.tmpl 2019-04-05 00:31:41 UTC (rev 243921)
@@ -106,6 +106,9 @@
<iframe src="" attachment.id %]"
style="width: 400px; height: 20px; border: none;" scrolling="no">
</iframe>
+ <iframe src="" attachment.id %]/"
+ style="width: 400px; height: 20px; border: none;" scrolling="no">
+ </iframe>
</div>
</td>
</tr>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
