Title: [244504] trunk/Tools
- Revision
- 244504
- Author
- aakash_j...@apple.com
- Date
- 2019-04-22 11:29:40 -0700 (Mon, 22 Apr 2019)
Log Message
[ews-build] Use singular verb in failure description in case of single api test failure
https://bugs.webkit.org/show_bug.cgi?id=197013
Reviewed by Lucas Forschler.
* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeAPITestsResults.analyzeResults):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (244503 => 244504)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-04-22 18:17:33 UTC (rev 244503)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-04-22 18:29:40 UTC (rev 244504)
@@ -807,7 +807,8 @@
self._addToLog('stderr', '\nNew failures: {}\n'.format(new_failures))
self.finished(FAILURE)
self.build.results = FAILURE
- message = 'Found {} new API Tests failures: {}'.format(len(new_failures), new_failures_string)
+ pluralSuffix = 's' if len(new_failures) > 1 else ''
+ message = 'Found {} new API Test failure{}: {}'.format(len(new_failures), pluralSuffix, new_failures_string)
self.descriptionDone = message
self.build.buildFinished([message], FAILURE)
else:
@@ -815,7 +816,8 @@
self.finished(SUCCESS)
self.build.results = SUCCESS
self.descriptionDone = 'Passed API tests'
- message = 'Found {} pre-existing API tests failures'.format(len(clean_tree_failures))
+ pluralSuffix = 's' if len(clean_tree_failures) > 1 else ''
+ message = 'Found {} pre-existing API test failure{}'.format(len(clean_tree_failures), pluralSuffix)
if flaky_failures:
message += '. Flaky tests: {}'.format(flaky_failures_string)
self.build.buildFinished([message], SUCCESS)
Modified: trunk/Tools/ChangeLog (244503 => 244504)
--- trunk/Tools/ChangeLog 2019-04-22 18:17:33 UTC (rev 244503)
+++ trunk/Tools/ChangeLog 2019-04-22 18:29:40 UTC (rev 244504)
@@ -1,3 +1,13 @@
+2019-04-22 Aakash Jain <aakash_j...@apple.com>
+
+ [ews-build] Use singular verb in failure description in case of single api test failure
+ https://bugs.webkit.org/show_bug.cgi?id=197013
+
+ Reviewed by Lucas Forschler.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (AnalyzeAPITestsResults.analyzeResults):
+
2019-04-22 Chris Dumez <cdu...@apple.com>
Delayed WebProcessLaunch may break the _relatedWebView SPI
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
