Title: [245987] trunk/Source
- Revision
- 245987
- Author
- gga...@apple.com
- Date
- 2019-05-31 14:56:37 -0700 (Fri, 31 May 2019)
Log Message
Some WeakPtr typedef cleanup
https://bugs.webkit.org/show_bug.cgi?id=198431
Reviewed by Chris Dumez.
Use "using" instead of "typedef", since using is preferred in C++ for
better compatibility with templates.
Source/WebCore:
* Modules/indexeddb/shared/InProcessIDBServer.h:
* html/HTMLMediaElement.h:
* platform/ScrollView.h:
Source/WebKit:
* UIProcess/WebAuthentication/AuthenticatorManager.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (245986 => 245987)
--- trunk/Source/WebCore/ChangeLog 2019-05-31 21:32:04 UTC (rev 245986)
+++ trunk/Source/WebCore/ChangeLog 2019-05-31 21:56:37 UTC (rev 245987)
@@ -1,3 +1,17 @@
+2019-05-31 Geoffrey Garen <gga...@apple.com>
+
+ Some WeakPtr typedef cleanup
+ https://bugs.webkit.org/show_bug.cgi?id=198431
+
+ Reviewed by Chris Dumez.
+
+ Use "using" instead of "typedef", since using is preferred in C++ for
+ better compatibility with templates.
+
+ * Modules/indexeddb/shared/InProcessIDBServer.h:
+ * html/HTMLMediaElement.h:
+ * platform/ScrollView.h:
+
2019-05-31 Andres Gonzalez <andresg...@apple.com>
Inserting a newline in contenteditable causes two characters to be added instead of one
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h (245986 => 245987)
--- trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h 2019-05-31 21:32:04 UTC (rev 245986)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h 2019-05-31 21:56:37 UTC (rev 245987)
@@ -54,7 +54,7 @@
class InProcessIDBServer final : public IDBClient::IDBConnectionToServerDelegate, public IDBServer::IDBConnectionToClientDelegate, public RefCounted<InProcessIDBServer>, public IDBServer::IDBBackingStoreTemporaryFileHandler {
public:
using IDBClient::IDBConnectionToServerDelegate::weakPtrFactory;
- typedef IDBClient::IDBConnectionToServerDelegate::WeakValueType WeakValueType;
+ using WeakValueType = IDBClient::IDBConnectionToServerDelegate::WeakValueType;
WEBCORE_EXPORT static Ref<InProcessIDBServer> create(PAL::SessionID);
WEBCORE_EXPORT static Ref<InProcessIDBServer> create(PAL::SessionID, const String& databaseDirectoryPath);
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (245986 => 245987)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2019-05-31 21:32:04 UTC (rev 245986)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2019-05-31 21:56:37 UTC (rev 245987)
@@ -149,7 +149,7 @@
{
WTF_MAKE_ISO_ALLOCATED(HTMLMediaElement);
public:
- typedef HTMLElement::WeakValueType WeakValueType;
+ using WeakValueType = HTMLElement::WeakValueType;
using HTMLElement::weakPtrFactory;
RefPtr<MediaPlayer> player() const { return m_player; }
Modified: trunk/Source/WebCore/platform/ScrollView.h (245986 => 245987)
--- trunk/Source/WebCore/platform/ScrollView.h 2019-05-31 21:32:04 UTC (rev 245986)
+++ trunk/Source/WebCore/platform/ScrollView.h 2019-05-31 21:56:37 UTC (rev 245987)
@@ -65,7 +65,7 @@
public:
virtual ~ScrollView();
- typedef Widget::WeakValueType WeakValueType;
+ using WeakValueType = Widget::WeakValueType;
using Widget::weakPtrFactory;
// ScrollableArea functions.
Modified: trunk/Source/WebKit/ChangeLog (245986 => 245987)
--- trunk/Source/WebKit/ChangeLog 2019-05-31 21:32:04 UTC (rev 245986)
+++ trunk/Source/WebKit/ChangeLog 2019-05-31 21:56:37 UTC (rev 245987)
@@ -1,3 +1,15 @@
+2019-05-31 Geoffrey Garen <gga...@apple.com>
+
+ Some WeakPtr typedef cleanup
+ https://bugs.webkit.org/show_bug.cgi?id=198431
+
+ Reviewed by Chris Dumez.
+
+ Use "using" instead of "typedef", since using is preferred in C++ for
+ better compatibility with templates.
+
+ * UIProcess/WebAuthentication/AuthenticatorManager.h:
+
2019-05-31 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r245953.
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h (245986 => 245987)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h 2019-05-31 21:32:04 UTC (rev 245986)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h 2019-05-31 21:56:37 UTC (rev 245987)
@@ -49,7 +49,7 @@
using TransportSet = HashSet<WebCore::AuthenticatorTransport, WTF::IntHash<WebCore::AuthenticatorTransport>, WTF::StrongEnumHashTraits<WebCore::AuthenticatorTransport>>;
using AuthenticatorTransportService::Observer::weakPtrFactory;
- typedef AuthenticatorTransportService::Observer::WeakValueType WeakValueType;
+ using WeakValueType = AuthenticatorTransportService::Observer::WeakValueType;
AuthenticatorManager();
virtual ~AuthenticatorManager() = default;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
