Title: [245994] trunk/LayoutTests
Revision
245994
Author
simon.fra...@apple.com
Date
2019-05-31 16:20:14 -0700 (Fri, 31 May 2019)

Log Message

[Mac WK2 Debug] Layout Test scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=197425

Unreviewed test gardening.

Speculative fix for flakey test; trigger layout inside the subframe.

* scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (245993 => 245994)


--- trunk/LayoutTests/ChangeLog	2019-05-31 23:13:39 UTC (rev 245993)
+++ trunk/LayoutTests/ChangeLog	2019-05-31 23:20:14 UTC (rev 245994)
@@ -1,3 +1,16 @@
+2019-05-31  Nikita Vasilyev  <nvasil...@apple.com>
+
+        Web Inspector: CSS Changes: modifications aren't shared for rules that match multiple elements
+        https://bugs.webkit.org/show_bug.cgi?id=195264
+        <rdar://problem/48550023>
+
+        Reviewed by Devin Rousso.
+
+        Test arrays with repeating items for Array.diffArrays.
+
+        * inspector/unit-tests/array-utilities-expected.txt:
+        * inspector/unit-tests/array-utilities.html:
+
 2019-05-31  Ryosuke Niwa  <rn...@webkit.org>
 
         [iOS] Reveal the focused element when it's immediately above software keyboard
@@ -11,19 +24,17 @@
         * fast/scrolling/ios/reveal-focused-element-right-above-keyboard-on-ipad-expected.txt: Added.
         * fast/scrolling/ios/reveal-focused-element-right-above-keyboard-on-ipad.html: Added.
 
-2019-05-31  Nikita Vasilyev  <nvasil...@apple.com>
+2019-05-31  Simon Fraser  <simon.fra...@apple.com>
 
-        Web Inspector: CSS Changes: modifications aren't shared for rules that match multiple elements
-        https://bugs.webkit.org/show_bug.cgi?id=195264
-        <rdar://problem/48550023>
+        [Mac WK2 Debug] Layout Test scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=197425
 
-        Reviewed by Devin Rousso.
+        Unreviewed test gardening.
+        
+        Speculative fix for flakey test; trigger layout inside the subframe.
 
-        Test arrays with repeating items for Array.diffArrays.
+        * scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html:
 
-        * inspector/unit-tests/array-utilities-expected.txt:
-        * inspector/unit-tests/array-utilities.html:
-
 2019-05-31  Ryosuke Niwa  <rn...@webkit.org>
 
         iOS: Main frame should be scrollable when pinch zoomed or software keyboard is up

Modified: trunk/LayoutTests/scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html (245993 => 245994)


--- trunk/LayoutTests/scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html	2019-05-31 23:13:39 UTC (rev 245993)
+++ trunk/LayoutTests/scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html	2019-05-31 23:20:14 UTC (rev 245994)
@@ -11,8 +11,11 @@
           window.internals.settings.setAsyncFrameScrollingEnabled(true);
       function doTest()
       {
-          if (window.internals)
-              document.getElementById('scrollingTree').innerText = window.internals.scrollingStateTreeAsText() + "\n";
+          if (window.internals) {
+			  subframe.contentWindow.internals.scrollingStateTreeAsText(); // Trigger frame layout.
+              document.getElementById('scrollingTree').innerText = internals.scrollingStateTreeAsText() + "\n";
+          }
+
           if (window.testRunner)
               testRunner.notifyDone();
       }
@@ -31,7 +34,7 @@
     </style>
   </head>
   <body>
-    <iframe _onload_="doTest()" srcdoc="
+    <iframe id="subframe" _onload_="doTest()" srcdoc="
         <div style='width: 300px; height: 400px; background: gray;'></div>">
     </iframe>
     <pre id="scrollingTree"></pre>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to