Title: [247404] trunk/Tools
- Revision
- 247404
- Author
- commit-qu...@webkit.org
- Date
- 2019-07-12 15:51:47 -0700 (Fri, 12 Jul 2019)
Log Message
Enable client certificate authentication unit test
https://bugs.webkit.org/show_bug.cgi?id=199735
Patch by Alex Christensen <achristen...@webkit.org> on 2019-07-12
Reviewed by Chris Dumez.
* TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
(TEST):
I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
I found what was crashing. I was reading out of bounds on my vector of 2 strings :(
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (247403 => 247404)
--- trunk/Tools/ChangeLog 2019-07-12 22:15:55 UTC (rev 247403)
+++ trunk/Tools/ChangeLog 2019-07-12 22:51:47 UTC (rev 247404)
@@ -1,5 +1,17 @@
2019-07-12 Alex Christensen <achristen...@webkit.org>
+ Enable client certificate authentication unit test
+ https://bugs.webkit.org/show_bug.cgi?id=199735
+
+ Reviewed by Chris Dumez.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
+ (TEST):
+ I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
+ I found what was crashing. I was reading out of bounds on my vector of 2 strings :(
+
+2019-07-12 Alex Christensen <achristen...@webkit.org>
+
Begin unifying TestWebKitAPI build
https://bugs.webkit.org/show_bug.cgi?id=199728
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm (247403 => 247404)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm 2019-07-12 22:15:55 UTC (rev 247403)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm 2019-07-12 22:51:47 UTC (rev 247404)
@@ -145,7 +145,7 @@
@end
#if HAVE(SEC_KEY_PROXY)
-TEST(Challenge, DISABLED_ClientCertificate)
+TEST(Challenge, ClientCertificate)
{
using namespace TestWebKitAPI;
TCPServer server(TCPServer::Protocol::HTTPSWithClientCertificateRequest, TCPServer::respondWithOK);
@@ -159,7 +159,7 @@
auto& methods = [delegate authenticationMethods];
EXPECT_EQ(methods.size(), 2ull);
EXPECT_TRUE([methods[0] isEqualToString:NSURLAuthenticationMethodServerTrust]);
- EXPECT_TRUE([methods[2] isEqualToString:NSURLAuthenticationMethodClientCertificate]);
+ EXPECT_TRUE([methods[1] isEqualToString:NSURLAuthenticationMethodClientCertificate]);
}
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
