Title: [248045] trunk/Websites/perf.webkit.org
- Revision
- 248045
- Author
- dewei_...@apple.com
- Date
- 2019-07-31 09:28:02 -0700 (Wed, 31 Jul 2019)
Log Message
Analysis task page should show build request author and creation time.
https://bugs.webkit.org/show_bug.cgi?id=200274
Reviewed by Ryosuke Niwa.
Author and creation time of a build request should be visible in analysis task page.
* public/v3/pages/analysis-task-page.js: Added UI to show build request creation time and author.
(AnalysisTaskTestGroupPane.prototype._renderCurrentTestGroup):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (248044 => 248045)
--- trunk/Websites/perf.webkit.org/ChangeLog 2019-07-31 16:26:57 UTC (rev 248044)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2019-07-31 16:28:02 UTC (rev 248045)
@@ -1,3 +1,15 @@
+2019-07-30 Dewei Zhu <dewei_...@apple.com>
+
+ Analysis task page should show build request author and creation time.
+ https://bugs.webkit.org/show_bug.cgi?id=200274
+
+ Reviewed by Ryosuke Niwa.
+
+ Author and creation time of a build request should be visible in analysis task page.
+
+ * public/v3/pages/analysis-task-page.js: Added UI to show build request creation time and author.
+ (AnalysisTaskTestGroupPane.prototype._renderCurrentTestGroup):
+
2019-07-29 Dewei Zhu <dewei_...@apple.com>
Should not render latest build information if there is no data points for a config.
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js (248044 => 248045)
--- trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js 2019-07-31 16:26:57 UTC (rev 248044)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js 2019-07-31 16:28:02 UTC (rev 248045)
@@ -371,12 +371,16 @@
if (currentGroup) {
this.part('retry-form').setRepetitionCount(currentGroup.initialRepetitionCount());
this.part('bisect-form').setRepetitionCount(currentGroup.initialRepetitionCount());
- const summary = `${currentGroup.initialRepetitionCount()} requested, ${currentGroup.repetitionCount() - currentGroup.initialRepetitionCount()} added due to failures.`;
- this.content('status-summary').innerHTML = summary;
+ const statusSummary = `${currentGroup.initialRepetitionCount()} requested, ${currentGroup.repetitionCount() - currentGroup.initialRepetitionCount()} added due to failures.`;
+ this.content('status-summary').innerHTML = statusSummary;
+
+ const authoredBy = currentGroup.author() ? `by "${currentGroup.author()}"` : '';
+ this.content('request-summary').innerHTML = `Scheduled ${authoredBy} at ${currentGroup.createdAt()}`
}
this.content('retry-form').style.display = currentGroup ? null : 'none';
this.content('bisect-form').style.display = currentGroup && this._bisectingCommitSetByTestGroup.get(currentGroup) ? null : 'none';
this.content('status-summary').style.display = currentGroup && currentGroup.repetitionCount() > currentGroup.initialRepetitionCount() ? null : 'none';
+ this.content('request-summary').style.display = currentGroup ? null : 'none';
const hideButton = this.content('hide-button');
hideButton.textContent = currentGroup && currentGroup.isHidden() ? 'Unhide' : 'Hide';
@@ -393,6 +397,7 @@
<test-group-results-viewer id="results-viewer"></test-group-results-viewer>
<test-group-revision-table id="revision-table"></test-group-revision-table>
<div id="status-summary" class="summary"></div>
+ <div id="request-summary" class="summary"></div>
<test-group-form id="retry-form">Retry</test-group-form>
<test-group-form id="bisect-form">Bisect</test-group-form>
<button id="hide-button">Hide</button>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
