Title: [248110] trunk/Websites/perf.webkit.org
- Revision
- 248110
- Author
- dewei_...@apple.com
- Date
- 2019-08-01 11:02:45 -0700 (Thu, 01 Aug 2019)
Log Message
Dashboard should defaults to first dashboard page when summary page is not available.
https://bugs.webkit.org/show_bug.cgi?id=200180
Reviewed by Ryosuke Niwa.
Fix a bug that charts page will become the default when there is no summary page but there
is at least one dashboard page.
* public/v3/main.js: Charts page and analysis category page should not be considered as summay pages.
(main):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (248109 => 248110)
--- trunk/Websites/perf.webkit.org/ChangeLog 2019-08-01 17:55:54 UTC (rev 248109)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2019-08-01 18:02:45 UTC (rev 248110)
@@ -1,3 +1,16 @@
+2019-07-26 Dewei Zhu <dewei_...@apple.com>
+
+ Dashboard should defaults to first dashboard page when summary page is not available.
+ https://bugs.webkit.org/show_bug.cgi?id=200180
+
+ Reviewed by Ryosuke Niwa.
+
+ Fix a bug that charts page will become the default when there is no summary page but there
+ is at least one dashboard page.
+
+ * public/v3/main.js: Charts page and analysis category page should not be considered as summay pages.
+ (main):
+
2019-07-30 Dewei Zhu <dewei_...@apple.com>
Analysis task page should show build request author and creation time.
Modified: trunk/Websites/perf.webkit.org/public/v3/main.js (248109 => 248110)
--- trunk/Websites/perf.webkit.org/public/v3/main.js 2019-08-01 17:55:54 UTC (rev 248109)
+++ trunk/Websites/perf.webkit.org/public/v3/main.js 2019-08-01 18:02:45 UTC (rev 248110)
@@ -38,8 +38,6 @@
const chartsPage = new ChartsPage(chartsToolbar);
const analysisCategoryPage = new AnalysisCategoryPage();
- summaryPages.push(chartsPage);
- summaryPages.push(analysisCategoryPage);
if (testFreshnessPage)
summaryPages.push(testFreshnessPage);
@@ -53,7 +51,7 @@
buildRequestQueuePage.setParentPage(analysisCategoryPage);
const heading = new Heading(manifest.siteTitle);
- heading.addPageGroup(summaryPages);
+ heading.addPageGroup([chartsPage, analysisCategoryPage, ...summaryPages]);
heading.setTitle(manifest.siteTitle);
heading.addPageGroup(dashboardPages);
@@ -61,6 +59,8 @@
const router = new PageRouter();
for (const summaryPage of summaryPages)
router.addPage(summaryPage);
+ router.addPage(chartsPage);
+ router.addPage(analysisCategoryPage);
router.addPage(createAnalysisTaskPage);
router.addPage(analysisTaskPage);
router.addPage(buildRequestQueuePage);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
