Title: [249060] trunk/LayoutTests
- Revision
- 249060
- Author
- commit-qu...@webkit.org
- Date
- 2019-08-23 12:21:32 -0700 (Fri, 23 Aug 2019)
Log Message
REGRESSION: fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=201075
<rdar://problem/54491246>
Patch by Antoine Quint <grao...@apple.com> on 2019-08-23
Reviewed by Daniel Bates.
This test was written very early on in the process of implementing Pointer Events and assumed events would keep
firing when scrolling occured. We need to add "touch-action: none" to ensure we get pointermove and pointerup
events. We also need to ensure that the interaction occurs over content otherwise events won't fire. Finally, we
pretty up the test a bit.
* fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup-expected.txt:
* fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (249059 => 249060)
--- trunk/LayoutTests/ChangeLog 2019-08-23 18:56:03 UTC (rev 249059)
+++ trunk/LayoutTests/ChangeLog 2019-08-23 19:21:32 UTC (rev 249060)
@@ -1,3 +1,19 @@
+2019-08-23 Antoine Quint <grao...@apple.com>
+
+ REGRESSION: fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=201075
+ <rdar://problem/54491246>
+
+ Reviewed by Daniel Bates.
+
+ This test was written very early on in the process of implementing Pointer Events and assumed events would keep
+ firing when scrolling occured. We need to add "touch-action: none" to ensure we get pointermove and pointerup
+ events. We also need to ensure that the interaction occurs over content otherwise events won't fire. Finally, we
+ pretty up the test a bit.
+
+ * fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup-expected.txt:
+ * fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html:
+
2019-08-20 Jiewen Tan <jiewen_...@apple.com>
[WebAuthn] Support NFC authenticators for iOS
Modified: trunk/LayoutTests/fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup-expected.txt (249059 => 249060)
--- trunk/LayoutTests/fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup-expected.txt 2019-08-23 18:56:03 UTC (rev 249059)
+++ trunk/LayoutTests/fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup-expected.txt 2019-08-23 19:21:32 UTC (rev 249060)
@@ -5,7 +5,6 @@
pointerdown fired.
-Remove this when bug 19133 is fixed.
At least one pointermove was fired.
pointerup fired.
PASS successfullyParsed is true
Modified: trunk/LayoutTests/fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html (249059 => 249060)
--- trunk/LayoutTests/fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html 2019-08-23 18:56:03 UTC (rev 249059)
+++ trunk/LayoutTests/fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html 2019-08-23 19:21:32 UTC (rev 249060)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ experimental:PointerEventsEnabled=true ] -->
+<!DOCTYPE html>
<html>
<head>
<script src=""
@@ -6,6 +6,7 @@
<style>
body {
margin: none;
+ touch-action: none;
}
</style>
<meta name="viewport" content="initial-scale=1">
@@ -20,34 +21,22 @@
function runTest()
{
- // FIXME: At the moment a touch listener is required due
- // to the way pointer events are dispatched.
- // https://bugs.webkit.org/show_bug.cgi?id=191333
- window.addEventListener("touchstart", (event) => {
- debug("Remove this when bug 19133 is fixed.");
- });
+ window.addEventListener("pointerdown", event => debug("pointerdown fired."));
- window.addEventListener("pointerdown", (event) => {
- debug("pointerdown fired.");
- });
-
- seenMove = false;
- window.addEventListener("pointermove", (event) => {
+ let seenMove = false;
+ window.addEventListener("pointermove", event => {
if (!seenMove)
debug("At least one pointermove was fired.");
seenMove = true;
});
- window.addEventListener("pointerup", (event) => {
+ window.addEventListener("pointerup", event => {
debug("pointerup fired.");
finishJSTest();
});
- if (window.testRunner) {
- touchAndDragFromPointToPoint(50, 200, 60, 210).then(() => {
- liftUpAtPoint(60, 210);
- });
- }
+ if (window.testRunner)
+ touchAndDragFromPointToPoint(50, 50, 40, 40).then(() => liftUpAtPoint(40, 40));
}
window.addEventListener("load", runTest, false);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
