Title: [249072] trunk/LayoutTests
- Revision
- 249072
- Author
- timothy_hor...@apple.com
- Date
- 2019-08-23 15:54:48 -0700 (Fri, 23 Aug 2019)
Log Message
REGRESSION (r248974): fast/events/ios/key-command-delete-to-end-of-paragraph.html is timing out on iOS
https://bugs.webkit.org/show_bug.cgi?id=201091
<rdar://problem/54647731>
Reviewed by Megan Gardner.
* fast/events/ios/key-command-delete-to-end-of-paragraph.html:
The test as-written doesn't actually wait for the tap to complete before
continuing on with the test - it starts immediately when the focus event
fires. This results in the selection being changed by the single click
handler *after* focusing the field.
Rewrite the test to await completion of the tap before moving forward
instead of waiting for focus.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (249071 => 249072)
--- trunk/LayoutTests/ChangeLog 2019-08-23 22:17:07 UTC (rev 249071)
+++ trunk/LayoutTests/ChangeLog 2019-08-23 22:54:48 UTC (rev 249072)
@@ -1,3 +1,20 @@
+2019-08-23 Tim Horton <timothy_hor...@apple.com>
+
+ REGRESSION (r248974): fast/events/ios/key-command-delete-to-end-of-paragraph.html is timing out on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=201091
+ <rdar://problem/54647731>
+
+ Reviewed by Megan Gardner.
+
+ * fast/events/ios/key-command-delete-to-end-of-paragraph.html:
+ The test as-written doesn't actually wait for the tap to complete before
+ continuing on with the test - it starts immediately when the focus event
+ fires. This results in the selection being changed by the single click
+ handler *after* focusing the field.
+
+ Rewrite the test to await completion of the tap before moving forward
+ instead of waiting for focus.
+
2019-08-23 Chris Dumez <cdu...@apple.com>
[geolocation] Rename interfaces and remove [NoInterfaceObject]
Modified: trunk/LayoutTests/fast/events/ios/key-command-delete-to-end-of-paragraph.html (249071 => 249072)
--- trunk/LayoutTests/fast/events/ios/key-command-delete-to-end-of-paragraph.html 2019-08-23 22:17:07 UTC (rev 249071)
+++ trunk/LayoutTests/fast/events/ios/key-command-delete-to-end-of-paragraph.html 2019-08-23 22:54:48 UTC (rev 249072)
@@ -35,7 +35,7 @@
finishJSTest();
}
-function runTest()
+async function runTest()
{
if (!window.testRunner)
document.getElementById("manual-instructions").classList.remove("hidden");
@@ -48,9 +48,12 @@
if (window.testRunner)
UIHelper.keyDown("k", ["ctrlKey"]);
}
- testElement.addEventListener("focus", handleFocus, { once: true });
- if (window.testRunner)
- UIHelper.activateElement(testElement);
+
+ if (window.testRunner) {
+ await UIHelper.activateElement(testElement);
+ handleFocus();
+ } else
+ testElement.addEventListener("focus", handleFocus, { once: true });
}
description("Tests that pressing Control + k in a content-editable field deletes to the end of the paragraph.");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
