Title: [250161] trunk/Source/WebCore
- Revision
- 250161
- Author
- krol...@apple.com
- Date
- 2019-09-20 15:58:55 -0700 (Fri, 20 Sep 2019)
Log Message
Remove check of setSourceAppPid selector that's no longer needed
https://bugs.webkit.org/show_bug.cgi?id=201971
<rdar://problem/55505761>
Reviewed by Andy Estes.
Bug 172152 introduced a check of the NEFilterSource selector
setSourceAppPid in order to support OS's that didn't support it. All
supported Cocoa platforms now support it, so the check can be removed.
Source/WebCore:
No new tests -- no new or changed functionality.
* platform/cocoa/NetworkExtensionContentFilter.mm:
(WebCore::NetworkExtensionContentFilter::initialize):
Source/WebCore/PAL:
* pal/spi/cocoa/NEFilterSourceSPI.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (250160 => 250161)
--- trunk/Source/WebCore/ChangeLog 2019-09-20 22:19:55 UTC (rev 250160)
+++ trunk/Source/WebCore/ChangeLog 2019-09-20 22:58:55 UTC (rev 250161)
@@ -1,5 +1,22 @@
2019-09-20 Keith Rollin <krol...@apple.com>
+ Remove check of setSourceAppPid selector that's no longer needed
+ https://bugs.webkit.org/show_bug.cgi?id=201971
+ <rdar://problem/55505761>
+
+ Reviewed by Andy Estes.
+
+ Bug 172152 introduced a check of the NEFilterSource selector
+ setSourceAppPid in order to support OS's that didn't support it. All
+ supported Cocoa platforms now support it, so the check can be removed.
+
+ No new tests -- no new or changed functionality.
+
+ * platform/cocoa/NetworkExtensionContentFilter.mm:
+ (WebCore::NetworkExtensionContentFilter::initialize):
+
+2019-09-20 Keith Rollin <krol...@apple.com>
+
Remove some support for < iOS 13
https://bugs.webkit.org/show_bug.cgi?id=201967
<rdar://problem/55504738>
Modified: trunk/Source/WebCore/PAL/ChangeLog (250160 => 250161)
--- trunk/Source/WebCore/PAL/ChangeLog 2019-09-20 22:19:55 UTC (rev 250160)
+++ trunk/Source/WebCore/PAL/ChangeLog 2019-09-20 22:58:55 UTC (rev 250161)
@@ -1,5 +1,19 @@
2019-09-20 Keith Rollin <krol...@apple.com>
+ Remove check of setSourceAppPid selector that's no longer needed
+ https://bugs.webkit.org/show_bug.cgi?id=201971
+ <rdar://problem/55505761>
+
+ Reviewed by Andy Estes.
+
+ Bug 172152 introduced a check of the NEFilterSource selector
+ setSourceAppPid in order to support OS's that didn't support it. All
+ supported Cocoa platforms now support it, so the check can be removed.
+
+ * pal/spi/cocoa/NEFilterSourceSPI.h:
+
+2019-09-20 Keith Rollin <krol...@apple.com>
+
Remove some support for < iOS 13
https://bugs.webkit.org/show_bug.cgi?id=201967
<rdar://problem/55504738>
Modified: trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm (250160 => 250161)
--- trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm 2019-09-20 22:19:55 UTC (rev 250160)
+++ trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm 2019-09-20 22:58:55 UTC (rev 250161)
@@ -43,11 +43,6 @@
SOFT_LINK_FRAMEWORK_OPTIONAL(NetworkExtension);
SOFT_LINK_CLASS_OPTIONAL(NetworkExtension, NEFilterSource);
-// FIXME: Remove this once -setSourceAppPid: is declared in an SDK used by the builders
-@interface NEFilterSource ()
-- (void)setSourceAppPid:(pid_t)sourceAppPid;
-@end
-
static inline NSData *replacementDataFromDecisionInfo(NSDictionary *decisionInfo)
{
ASSERT_WITH_SECURITY_IMPLICATION(!decisionInfo || [decisionInfo isKindOfClass:[NSDictionary class]]);
@@ -77,9 +72,7 @@
m_neFilterSource = adoptNS([allocNEFilterSourceInstance() initWithDecisionQueue:m_queue.get()]);
#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)
[m_neFilterSource setSourceAppIdentifier:applicationBundleIdentifier()];
- // FIXME: Remove the -respondsToSelector: check once -setSourceAppPid: is defined in an SDK used by the builders.
- if ([m_neFilterSource respondsToSelector:@selector(setSourceAppPid:)])
- [m_neFilterSource setSourceAppPid:presentingApplicationPID()];
+ [m_neFilterSource setSourceAppPid:presentingApplicationPID()];
#endif
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
