Title: [250562] trunk/Tools
- Revision
- 250562
- Author
- ddkil...@apple.com
- Date
- 2019-10-01 10:10:55 -0700 (Tue, 01 Oct 2019)
Log Message
clang-tidy: Fix unnecessary copying/ref churn of for loop variables in Tools
<https://webkit.org/b/202387>
Reviewed by Darin Adler.
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::setAllowedMenuActions): Make loop variable
a reference to fix unnecessary copying/ref churn.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (250561 => 250562)
--- trunk/Tools/ChangeLog 2019-10-01 16:51:24 UTC (rev 250561)
+++ trunk/Tools/ChangeLog 2019-10-01 17:10:55 UTC (rev 250562)
@@ -1,3 +1,14 @@
+2019-10-01 David Kilzer <ddkil...@apple.com>
+
+ clang-tidy: Fix unnecessary copying/ref churn of for loop variables in Tools
+ <https://webkit.org/b/202387>
+
+ Reviewed by Darin Adler.
+
+ * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+ (WTR::TestController::setAllowedMenuActions): Make loop variable
+ a reference to fix unnecessary copying/ref churn.
+
2019-10-01 Nikolas Zimmermann <nzimmerm...@igalia.com>
Update my affiliation - since today I work for Igalia.
Modified: trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm (250561 => 250562)
--- trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm 2019-10-01 16:51:24 UTC (rev 250561)
+++ trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm 2019-10-01 17:10:55 UTC (rev 250562)
@@ -429,7 +429,7 @@
{
#if PLATFORM(IOS_FAMILY)
auto actionNames = adoptNS([[NSMutableArray<NSString *> alloc] initWithCapacity:actions.size()]);
- for (auto action : actions)
+ for (auto& action : actions)
[actionNames addObject:action];
[m_mainWebView->platformView() setAllowedMenuActions:actionNames.get()];
#else
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
