Title: [251438] trunk/Source/WebKit
- Revision
- 251438
- Author
- yu...@chromium.org
- Date
- 2019-10-22 10:04:42 -0700 (Tue, 22 Oct 2019)
Log Message
[GTK] Web Inspector: add an option for disabling minification and concatenation of inspector UI in release build
https://bugs.webkit.org/show_bug.cgi?id=203201
Reviewed by Carlos Garcia Campos.
Allow passing COMBINE_INSPECTOR_RESOURCES and COMBINE_TEST_RESOURCES as cmake arguments. This
enables to avoid minification of Web Inspector scripts in release binaries which is very
convenient during inspector UI development.
* InspectorGResources.cmake:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (251437 => 251438)
--- trunk/Source/WebKit/ChangeLog 2019-10-22 17:03:34 UTC (rev 251437)
+++ trunk/Source/WebKit/ChangeLog 2019-10-22 17:04:42 UTC (rev 251438)
@@ -1,3 +1,16 @@
+2019-10-22 Yury Semikhatsky <yu...@chromium.org>
+
+ [GTK] Web Inspector: add an option for disabling minification and concatenation of inspector UI in release build
+ https://bugs.webkit.org/show_bug.cgi?id=203201
+
+ Reviewed by Carlos Garcia Campos.
+
+ Allow passing COMBINE_INSPECTOR_RESOURCES and COMBINE_TEST_RESOURCES as cmake arguments. This
+ enables to avoid minification of Web Inspector scripts in release binaries which is very
+ convenient during inspector UI development.
+
+ * InspectorGResources.cmake:
+
2019-10-22 Adrian Perez de Castro <ape...@igalia.com>
[GTK][WPE] Fix non-unified builds after r251326
Modified: trunk/Source/WebKit/InspectorGResources.cmake (251437 => 251438)
--- trunk/Source/WebKit/InspectorGResources.cmake 2019-10-22 17:03:34 UTC (rev 251437)
+++ trunk/Source/WebKit/InspectorGResources.cmake 2019-10-22 17:04:42 UTC (rev 251438)
@@ -45,16 +45,20 @@
VERBATIM
)
- if (CMAKE_BUILD_TYPE STREQUAL "Debug")
- set(COMBINE_INSPECTOR_RESOURCES NO)
- set(COMBINE_TEST_RESOURCES YES)
- elseif (DEVELOPER_MODE)
- set(COMBINE_INSPECTOR_RESOURCES YES)
- set(COMBINE_TEST_RESOURCES YES)
- else ()
- set(COMBINE_INSPECTOR_RESOURCES YES)
- set(COMBINE_TEST_RESOURCES NO)
+ if (NOT DEFINED COMBINE_INSPECTOR_RESOURCES)
+ if (CMAKE_BUILD_TYPE STREQUAL "Debug")
+ set(COMBINE_INSPECTOR_RESOURCES NO)
+ else ()
+ set(COMBINE_INSPECTOR_RESOURCES YES)
+ endif ()
endif ()
+ if (NOT DEFINED COMBINE_TEST_RESOURCES)
+ if (CMAKE_BUILD_TYPE STREQUAL "Debug" OR DEVELOPER_MODE)
+ set(COMBINE_TEST_RESOURCES YES)
+ else ()
+ set(COMBINE_TEST_RESOURCES NO)
+ endif ()
+ endif ()
add_custom_command(
OUTPUT ${CMAKE_BINARY_DIR}/inspector-resources.stamp
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
