Title: [251628] trunk/LayoutTests
- Revision
- 251628
- Author
- yu...@chromium.org
- Date
- 2019-10-25 23:12:14 -0700 (Fri, 25 Oct 2019)
Log Message
[GTK] Layout test inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139359
Reviewed by Devin Rousso.
Renable the test on all platforms. With the current implementation of inspector client in tests
response to Debugger.resume is dispatched in the front-end synchronously and the front-end would
call InspectoTest.log when inspected script execution is not yet resumed.
* inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt:
* inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (251627 => 251628)
--- trunk/LayoutTests/ChangeLog 2019-10-26 04:53:33 UTC (rev 251627)
+++ trunk/LayoutTests/ChangeLog 2019-10-26 06:12:14 UTC (rev 251628)
@@ -1,3 +1,20 @@
+2019-10-25 Yury Semikhatsky <yu...@chromium.org>
+
+ [GTK] Layout test inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=139359
+
+ Reviewed by Devin Rousso.
+
+ Renable the test on all platforms. With the current implementation of inspector client in tests
+ response to Debugger.resume is dispatched in the front-end synchronously and the front-end would
+ call InspectoTest.log when inspected script execution is not yet resumed.
+
+ * inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt:
+ * inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html:
+ * platform/gtk/TestExpectations:
+ * platform/mac/TestExpectations:
+ * platform/win/TestExpectations:
+
2019-10-25 Eric Carlson <eric.carl...@apple.com>
Support for callbacks for manifest events
Modified: trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt (251627 => 251628)
--- trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt 2019-10-26 04:53:33 UTC (rev 251627)
+++ trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt 2019-10-26 06:12:14 UTC (rev 251628)
@@ -13,8 +13,8 @@
Response value is 12
Evaluating in DFG frame at frame[2]: 'localVal3'
Response value is 12
-Resumed from breakpoint
inside breakpointBasic
result: 42
+Resumed from breakpoint
Test complete
Modified: trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html (251627 => 251628)
--- trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html 2019-10-26 04:53:33 UTC (rev 251627)
+++ trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html 2019-10-26 06:12:14 UTC (rev 251628)
@@ -40,9 +40,6 @@
breakpointId = responseObject.result.breakpointId;
InspectorProtocol.sendCommand("Runtime.evaluate", {
_expression_: "dfgWithoutInline3();"
- }, function(responseObject) {
- ProtocolTest.log("Test complete");
- ProtocolTest.completeTest();
});
});
});
@@ -98,9 +95,12 @@
resumeFromBreakpoint();
return;
}
- InspectorProtocol.sendCommand("Debugger.resume", {}, function(responseObject) {
+ InspectorProtocol.awaitEvent({event: "Debugger.resumed"}).then(() => {
ProtocolTest.log("Resumed from breakpoint");
+ ProtocolTest.log("Test complete");
+ ProtocolTest.completeTest();
});
+ InspectorProtocol.sendCommand("Debugger.resume");
});
});
});
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (251627 => 251628)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2019-10-26 04:53:33 UTC (rev 251627)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2019-10-26 06:12:14 UTC (rev 251628)
@@ -1630,8 +1630,6 @@
webkit.org/b/136581 editing/pasteboard/drag-drop-dead-frame.html [ Failure Timeout Pass ]
-webkit.org/b/139359 inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html [ Failure Pass Timeout ]
-
webkit.org/b/139489 http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html [ Failure Pass ]
webkit.org/b/143475 media/audio-repaint.html [ Timeout Failure ImageOnlyFailure Pass ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (251627 => 251628)
--- trunk/LayoutTests/platform/mac/TestExpectations 2019-10-26 04:53:33 UTC (rev 251627)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2019-10-26 06:12:14 UTC (rev 251628)
@@ -622,7 +622,6 @@
webkit.org/b/123250 plugins/destroy-during-npp-new-object-with-fallback-content.html [ Pass Failure ]
-inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html
inspector/debugger/didSampleProbe-multiple-probes.html
inspector/debugger/nested-inspectors.html
Modified: trunk/LayoutTests/platform/win/TestExpectations (251627 => 251628)
--- trunk/LayoutTests/platform/win/TestExpectations 2019-10-26 04:53:33 UTC (rev 251627)
+++ trunk/LayoutTests/platform/win/TestExpectations 2019-10-26 06:12:14 UTC (rev 251628)
@@ -2492,8 +2492,6 @@
# [ Release ] inspector/layers/layers-blending-compositing-reasons.html [ Failure ]
# [ Debug ] inspector/layers/layers-blending-compositing-reasons.html [ Skip ]
# [ Release ] inspector/layers/layers-reflected-content.html [ Pass Timeout ]
-# [ Release ] inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html [ Failure ]
-# [ Debug ] inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html [ Skip ] # Debug Assertion
# inspector/debugger/removeBreakpoint.html [ Skip ] # Crashing
# inspector/debugger/searchInContent-linebreaks.html [ Pass Crash ] # Flaky
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
