Title: [251833] trunk/LayoutTests
- Revision
- 251833
- Author
- yu...@chromium.org
- Date
- 2019-10-30 21:54:46 -0700 (Wed, 30 Oct 2019)
Log Message
inspector-protocol/debugger/setBreakpoint-dfg.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=128736
Reviewed by Devin Rousso.
Reenabling the test on all platforms. Depending on the platform implementation of EventLoop
there is a difference in what is dispatched first when execution is resumed: previously
paused inspected script or commands from the inspector front-end. It would not be a problem
if InspectorFrontendAPI.dispatchMessageAsync actually delivered messages asynchronously.
With the current implementation though response to Debugger.resume
is dispatched in the front-end synchronously and the front-end would call InspectoTest.log
when inspected script execution is not yet resumed.
* TestExpectations:
* inspector/debugger/setBreakpoint-dfg-expected.txt:
* inspector/debugger/setBreakpoint-dfg.html: Print final 'PASS' output after exiting nested loop
so that it always appears last.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (251832 => 251833)
--- trunk/LayoutTests/ChangeLog 2019-10-31 03:47:34 UTC (rev 251832)
+++ trunk/LayoutTests/ChangeLog 2019-10-31 04:54:46 UTC (rev 251833)
@@ -1,3 +1,24 @@
+2019-10-30 Yury Semikhatsky <yu...@chromium.org>
+
+ inspector-protocol/debugger/setBreakpoint-dfg.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=128736
+
+ Reviewed by Devin Rousso.
+
+ Reenabling the test on all platforms. Depending on the platform implementation of EventLoop
+ there is a difference in what is dispatched first when execution is resumed: previously
+ paused inspected script or commands from the inspector front-end. It would not be a problem
+ if InspectorFrontendAPI.dispatchMessageAsync actually delivered messages asynchronously.
+ With the current implementation though response to Debugger.resume
+ is dispatched in the front-end synchronously and the front-end would call InspectoTest.log
+ when inspected script execution is not yet resumed.
+
+ * TestExpectations:
+ * inspector/debugger/setBreakpoint-dfg-expected.txt:
+ * inspector/debugger/setBreakpoint-dfg.html: Print final 'PASS' output after exiting nested loop
+ so that it always appears last.
+ * platform/gtk/TestExpectations:
+
2019-10-30 Simon Fraser <simon.fra...@apple.com>
Opacity should always serialize as a number
Modified: trunk/LayoutTests/TestExpectations (251832 => 251833)
--- trunk/LayoutTests/TestExpectations 2019-10-31 03:47:34 UTC (rev 251832)
+++ trunk/LayoutTests/TestExpectations 2019-10-31 04:54:46 UTC (rev 251833)
@@ -924,7 +924,6 @@
webkit.org/b/129639 inspector/dom/dom-search-crash.html [ Skip ]
-webkit.org/b/128736 inspector/debugger/setBreakpoint-dfg.html [ Failure Pass ]
webkit.org/b/134982 inspector/debugger/setBreakpoint-dfg-and-modify-local.html [ Failure Pass ]
webkit.org/b/202932 inspector/model/remote-object-weak-collection.html [ Pass Timeout Failure ]
Modified: trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-expected.txt (251832 => 251833)
--- trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-expected.txt 2019-10-31 03:47:34 UTC (rev 251832)
+++ trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-expected.txt 2019-10-31 04:54:46 UTC (rev 251833)
@@ -13,6 +13,6 @@
dfgWithoutInline result: 502500
Hit Breakpoint 2!
Removed Breakpoint 2!
+dfgWithInline result: 504500
PASS
-dfgWithInline result: 504500
Modified: trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg.html (251832 => 251833)
--- trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg.html 2019-10-31 03:47:34 UTC (rev 251832)
+++ trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg.html 2019-10-31 04:54:46 UTC (rev 251833)
@@ -69,14 +69,17 @@
InspectorProtocol.sendCommand("Debugger.removeBreakpoint", {"breakpointId": breakpointId}, function(responseObject) {
ProtocolTest.log("Removed Breakpoint " + breakpointsHit + "!");
- InspectorProtocol.sendCommand("Debugger.resume", {}, function(responseObject) {
- if (breakpointsHit == 2) {
- ProtocolTest.log("PASS");
- ProtocolTest.completeTest();
- }
- });
+ InspectorProtocol.sendCommand("Debugger.resume");
});
}
+ InspectorProtocol.eventHandler["Debugger.resumed"] = function(messageObject)
+ {
+ if (breakpointsHit < 2)
+ return;
+ ProtocolTest.assert(breakpointsHit == 2);
+ ProtocolTest.log("PASS");
+ ProtocolTest.completeTest();
+ }
}
</script>
</head>
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (251832 => 251833)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2019-10-31 03:47:34 UTC (rev 251832)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2019-10-31 04:54:46 UTC (rev 251833)
@@ -1639,7 +1639,6 @@
webkit.org/b/131545 media/media-event-listeners.html [ Failure Pass ]
-webkit.org/b/139364 inspector/debugger/setBreakpoint-dfg.html [ Failure Pass Timeout ]
webkit.org/b/143876 css3/viewport-percentage-lengths/vh-resize.html [ ImageOnlyFailure Pass ]
webkit.org/b/143983 fast/hidpi/image-srcset-svg-canvas.html [ ImageOnlyFailure Pass ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
