Title: [252361] trunk
Revision
252361
Author
clo...@igalia.com
Date
2019-11-12 06:42:11 -0800 (Tue, 12 Nov 2019)

Log Message

[GTK][WPE] Enable CSS Painting API
https://bugs.webkit.org/show_bug.cgi?id=190710

Reviewed by Don Olmstead.

.:

This enables the feature when building with experimental features enabled.

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:

Source/WebKit:

Enable the runtime feature by default on GTK/WPE when building with
experimental features enabled.

Covered by existing tests.

* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.h:

LayoutTests:

Unskip the tests that now pass.

* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

Diff

Modified: trunk/ChangeLog (252360 => 252361)


--- trunk/ChangeLog	2019-11-12 14:38:34 UTC (rev 252360)
+++ trunk/ChangeLog	2019-11-12 14:42:11 UTC (rev 252361)
@@ -1,3 +1,15 @@
+2019-11-12  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
+        [GTK][WPE] Enable CSS Painting API
+        https://bugs.webkit.org/show_bug.cgi?id=190710
+
+        Reviewed by Don Olmstead.
+
+        This enables the feature when building with experimental features enabled.
+
+        * Source/cmake/OptionsGTK.cmake:
+        * Source/cmake/OptionsWPE.cmake:
+
 2019-11-06  Carlos Garcia Campos  <cgar...@igalia.com>
 
         [GTK] Implement support for Pointer Lock API

Modified: trunk/LayoutTests/ChangeLog (252360 => 252361)


--- trunk/LayoutTests/ChangeLog	2019-11-12 14:38:34 UTC (rev 252360)
+++ trunk/LayoutTests/ChangeLog	2019-11-12 14:42:11 UTC (rev 252361)
@@ -1,5 +1,17 @@
 2019-11-12  Carlos Alberto Lopez Perez  <clo...@igalia.com>
 
+        [GTK][WPE] Enable CSS Painting API
+        https://bugs.webkit.org/show_bug.cgi?id=190710
+
+        Reviewed by Don Olmstead.
+
+        Unskip the tests that now pass.
+
+        * platform/gtk/TestExpectations:
+        * platform/wpe/TestExpectations:
+
+2019-11-12  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
         [Pointer Events WPT] Delete manual tests imported as layout tests
         https://bugs.webkit.org/show_bug.cgi?id=203996
 

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (252360 => 252361)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2019-11-12 14:38:34 UTC (rev 252360)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2019-11-12 14:42:11 UTC (rev 252361)
@@ -711,9 +711,6 @@
 # ENABLE(CSS_SCROLL_SNAP) is disabled.
 css3/scroll-snap [ Skip ]
 
-# ENABLE(CSS_PAINTING_API) is disabled.
-webkit.org/b/190710 fast/css-custom-paint [ Skip ]
-
 # ENABLE(WEBVTT_REGIONS) is disabled
 webkit.org/b/109570 media/track/regions-webvtt [ Skip ]
 webkit.org/b/109570 media/track/w3c [ Skip ]

Modified: trunk/LayoutTests/platform/wpe/TestExpectations (252360 => 252361)


--- trunk/LayoutTests/platform/wpe/TestExpectations	2019-11-12 14:38:34 UTC (rev 252360)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2019-11-12 14:42:11 UTC (rev 252361)
@@ -197,9 +197,6 @@
 # ENABLE_DARK_MODE_CSS is OFF in WPE.
 css-dark-mode [ Skip ]
 
-# ENABLE(CSS_PAINTING_API) is disabled
-webkit.org/b/190710 fast/css-custom-paint [ Skip ]
-
 # Tests below are copied from wk2 expectations, because we've marked
 #  as passing the whole fast/events directory.
 

Modified: trunk/Source/WebKit/ChangeLog (252360 => 252361)


--- trunk/Source/WebKit/ChangeLog	2019-11-12 14:38:34 UTC (rev 252360)
+++ trunk/Source/WebKit/ChangeLog	2019-11-12 14:42:11 UTC (rev 252361)
@@ -1,3 +1,18 @@
+2019-11-12  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
+        [GTK][WPE] Enable CSS Painting API
+        https://bugs.webkit.org/show_bug.cgi?id=190710
+
+        Reviewed by Don Olmstead.
+
+        Enable the runtime feature by default on GTK/WPE when building with
+        experimental features enabled.
+
+        Covered by existing tests.
+
+        * Shared/WebPreferences.yaml:
+        * Shared/WebPreferencesDefaultValues.h:
+
 2019-11-12  Carlos Garcia Campos  <cgar...@igalia.com>
 
         [GTK] WebDriver: implement new window command

Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (252360 => 252361)


--- trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-11-12 14:38:34 UTC (rev 252360)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-11-12 14:42:11 UTC (rev 252361)
@@ -1379,7 +1379,7 @@
 
 CSSPaintingAPIEnabled:
   type: bool
-  defaultValue: false
+  defaultValue: DEFAULT_CSS_PAINTING_API_ENABLED
   humanReadableName: "CSS Painting API"
   humanReadableDescription: "Enable the CSS Painting API"
   webcoreBinding: RuntimeEnabledFeatures

Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (252360 => 252361)


--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2019-11-12 14:38:34 UTC (rev 252360)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2019-11-12 14:42:11 UTC (rev 252361)
@@ -279,8 +279,10 @@
 #endif
 
 #if ENABLE(EXPERIMENTAL_FEATURES) && (PLATFORM(GTK) || PLATFORM(WPE))
+#define DEFAULT_CSS_PAINTING_API_ENABLED true
 #define DEFAULT_CSS_TYPED_OM_ENABLED true
 #else
+#define DEFAULT_CSS_PAINTING_API_ENABLED false
 #define DEFAULT_CSS_TYPED_OM_ENABLED false
 #endif
 

Modified: trunk/Source/cmake/OptionsGTK.cmake (252360 => 252361)


--- trunk/Source/cmake/OptionsGTK.cmake	2019-11-12 14:38:34 UTC (rev 252360)
+++ trunk/Source/cmake/OptionsGTK.cmake	2019-11-12 14:42:11 UTC (rev 252361)
@@ -164,6 +164,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SERVICE_WORKER PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SHAREABLE_RESOURCE PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_PAINTING_API PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
 
 include(GStreamerDependencies)

Modified: trunk/Source/cmake/OptionsWPE.cmake (252360 => 252361)


--- trunk/Source/cmake/OptionsWPE.cmake	2019-11-12 14:38:34 UTC (rev 252360)
+++ trunk/Source/cmake/OptionsWPE.cmake	2019-11-12 14:42:11 UTC (rev 252361)
@@ -60,6 +60,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL2 PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_PAINTING_API PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
 
 # Public options specific to the WPE port. Do not add any options here unless
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to