Title: [253179] trunk/LayoutTests
- Revision
- 253179
- Author
- yu...@chromium.org
- Date
- 2019-12-05 15:48:40 -0800 (Thu, 05 Dec 2019)
Log Message
Web Inspector: http/tests/inspector/target/pause-on-inline-debugger-statement.html is crashing in debug
https://bugs.webkit.org/show_bug.cgi?id=204901
Reviewed by Devin Rousso.
Restructured the test to avoid inadvertent alert() when navigating to a new
process. New logs are printed after inspected page has navigated.
* http/tests/inspector/target/pause-on-inline-debugger-statement-expected.txt:
* http/tests/inspector/target/pause-on-inline-debugger-statement.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (253178 => 253179)
--- trunk/LayoutTests/ChangeLog 2019-12-05 23:40:47 UTC (rev 253178)
+++ trunk/LayoutTests/ChangeLog 2019-12-05 23:48:40 UTC (rev 253179)
@@ -1,5 +1,18 @@
2019-12-05 Yury Semikhatsky <yu...@chromium.org>
+ Web Inspector: http/tests/inspector/target/pause-on-inline-debugger-statement.html is crashing in debug
+ https://bugs.webkit.org/show_bug.cgi?id=204901
+
+ Reviewed by Devin Rousso.
+
+ Restructured the test to avoid inadvertent alert() when navigating to a new
+ process. New logs are printed after inspected page has navigated.
+
+ * http/tests/inspector/target/pause-on-inline-debugger-statement-expected.txt:
+ * http/tests/inspector/target/pause-on-inline-debugger-statement.html:
+
+2019-12-05 Yury Semikhatsky <yu...@chromium.org>
+
Web Inspector: Avoid using Runtime.executionContextCreated to figure out the iframe's contentDocument node.
https://bugs.webkit.org/show_bug.cgi?id=122764
<rdar://problem/15222136>
Modified: trunk/LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement-expected.txt (253178 => 253179)
--- trunk/LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement-expected.txt 2019-12-05 23:40:47 UTC (rev 253178)
+++ trunk/LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement-expected.txt 2019-12-05 23:48:40 UTC (rev 253179)
@@ -1,2 +1,7 @@
-ALERT: PASS: Should pause on debugger statement.
Test page used to check that execution will break on inline 'debugger' statement after cross-origin navigation.
+
+
+== Running test suite: Target.PSON
+-- Running test case: InlineDebuggerStatement
+PASS: Should pause on debugger statement.
+
Modified: trunk/LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement.html (253178 => 253179)
--- trunk/LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement.html 2019-12-05 23:40:47 UTC (rev 253178)
+++ trunk/LayoutTests/http/tests/inspector/target/pause-on-inline-debugger-statement.html 2019-12-05 23:48:40 UTC (rev 253179)
@@ -11,24 +11,19 @@
suite.addTestCase({
name: "InlineDebuggerStatement",
description: "Check that new provisional page can be paused before navigation.",
- test(resolve, reject) {
- WI.debuggerManager.awaitEvent(WI.DebuggerManager.Event.Paused)
- .then(() => {
- InspectorTest.pass(`Should pause on debugger statement.`);
+ async test() {
+ const url = ""
+ WI.mainTarget.PageAgent.navigate(url);
- // Wait for page reload event to avoid race between test results flushing and the test completion.
- let pageLoadPromise = InspectorTest.awaitEvent(FrontendTestHarness.Event.TestPageDidLoad);
- //WI.mainTarget.DebuggerAgent.
- Promise.resolve().then(() => {
- WI.debuggerManager.resume();
- });
- return pageLoadPromise;
- })
- .then(resolve);
+ await WI.debuggerManager.awaitEvent(WI.DebuggerManager.Event.Paused);
+ // Wait for page reload event to avoid race between test results flushing and the test completion.
+ await Promise.all([
+ InspectorTest.awaitEvent(FrontendTestHarness.Event.TestPageDidLoad),
+ WI.debuggerManager.resume()
+ ]);
- const url = ""
- WI.mainTarget.PageAgent.navigate(url);
+ InspectorTest.pass(`Should pause on debugger statement.`);
}
});
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
