Title: [256881] trunk/Source/WebKit
- Revision
- 256881
- Author
- cdu...@apple.com
- Date
- 2020-02-18 16:13:59 -0800 (Tue, 18 Feb 2020)
Log Message
Drop getSandboxExtensionsForBlobFiles() as it is dead code
https://bugs.webkit.org/show_bug.cgi?id=207909
<rdar://problem/59562180>
Reviewed by Per Arne Vollan.
* NetworkProcess/NetworkProcess.cpp:
* NetworkProcess/NetworkProcess.h:
* UIProcess/Network/NetworkProcessProxy.cpp:
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.messages.in:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (256880 => 256881)
--- trunk/Source/WebKit/ChangeLog 2020-02-19 00:10:57 UTC (rev 256880)
+++ trunk/Source/WebKit/ChangeLog 2020-02-19 00:13:59 UTC (rev 256881)
@@ -1,3 +1,17 @@
+2020-02-18 Chris Dumez <cdu...@apple.com>
+
+ Drop getSandboxExtensionsForBlobFiles() as it is dead code
+ https://bugs.webkit.org/show_bug.cgi?id=207909
+ <rdar://problem/59562180>
+
+ Reviewed by Per Arne Vollan.
+
+ * NetworkProcess/NetworkProcess.cpp:
+ * NetworkProcess/NetworkProcess.h:
+ * UIProcess/Network/NetworkProcessProxy.cpp:
+ * UIProcess/Network/NetworkProcessProxy.h:
+ * UIProcess/Network/NetworkProcessProxy.messages.in:
+
2020-02-18 Alex Christensen <achristen...@webkit.org>
Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (256880 => 256881)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2020-02-19 00:10:57 UTC (rev 256880)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2020-02-19 00:13:59 UTC (rev 256881)
@@ -2377,13 +2377,6 @@
completionHandler();
}
-#if ENABLE(SANDBOX_EXTENSIONS)
-void NetworkProcess::getSandboxExtensionsForBlobFiles(const Vector<String>& filenames, CompletionHandler<void(SandboxExtension::HandleArray&&)>&& completionHandler)
-{
- parentProcessConnection()->sendWithAsyncReply(Messages::NetworkProcessProxy::GetSandboxExtensionsForBlobFiles(filenames), WTFMove(completionHandler));
-}
-#endif // ENABLE(SANDBOX_EXTENSIONS)
-
#if ENABLE(SERVICE_WORKER)
void NetworkProcess::forEachSWServer(const Function<void(SWServer&)>& callback)
{
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.h (256880 => 256881)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.h 2020-02-19 00:10:57 UTC (rev 256880)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.h 2020-02-19 00:13:59 UTC (rev 256881)
@@ -287,10 +287,6 @@
void resetQuota(PAL::SessionID, CompletionHandler<void()>&&);
-#if ENABLE(SANDBOX_EXTENSIONS)
- void getSandboxExtensionsForBlobFiles(const Vector<String>& filenames, CompletionHandler<void(SandboxExtension::HandleArray&&)>&&);
-#endif
-
#if ENABLE(SERVICE_WORKER)
WebCore::SWServer* swServerForSessionIfExists(PAL::SessionID sessionID) { return m_swServers.get(sessionID); }
WebCore::SWServer& swServerForSession(PAL::SessionID);
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (256880 => 256881)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2020-02-19 00:10:57 UTC (rev 256880)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2020-02-19 00:13:59 UTC (rev 256881)
@@ -1285,19 +1285,6 @@
}
#endif
-#if ENABLE(SANDBOX_EXTENSIONS)
-void NetworkProcessProxy::getSandboxExtensionsForBlobFiles(const Vector<String>& paths, Messages::NetworkProcessProxy::GetSandboxExtensionsForBlobFiles::AsyncReply&& reply)
-{
- SandboxExtension::HandleArray extensions;
- extensions.allocate(paths.size());
- for (size_t i = 0; i < paths.size(); ++i) {
- // ReadWrite is required for creating hard links, which is something that might be done with these extensions.
- SandboxExtension::createHandle(paths[i], SandboxExtension::Type::ReadWrite, extensions[i]);
- }
- reply(WTFMove(extensions));
-}
-#endif
-
#if ENABLE(SERVICE_WORKER)
void NetworkProcessProxy::establishWorkerContextConnectionToNetworkProcess(RegistrableDomain&& registrableDomain, PAL::SessionID sessionID, CompletionHandler<void()>&& completionHandler)
{
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h (256880 => 256881)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h 2020-02-19 00:10:57 UTC (rev 256880)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h 2020-02-19 00:13:59 UTC (rev 256881)
@@ -259,10 +259,6 @@
void contentExtensionRules(UserContentControllerIdentifier);
#endif
-#if ENABLE(SANDBOX_EXTENSIONS)
- void getSandboxExtensionsForBlobFiles(const Vector<String>& paths, Messages::NetworkProcessProxy::GetSandboxExtensionsForBlobFilesAsyncReply&&);
-#endif
-
#if ENABLE(SERVICE_WORKER)
void establishWorkerContextConnectionToNetworkProcess(WebCore::RegistrableDomain&&, PAL::SessionID, CompletionHandler<void()>&&);
void workerContextConnectionNoLongerNeeded(WebCore::ProcessIdentifier);
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in (256880 => 256881)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in 2020-02-19 00:10:57 UTC (rev 256880)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in 2020-02-19 00:13:59 UTC (rev 256881)
@@ -57,10 +57,6 @@
RetrieveCacheStorageParameters(PAL::SessionID sessionID)
-#if ENABLE(SANDBOX_EXTENSIONS)
- GetSandboxExtensionsForBlobFiles(Vector<String> paths) -> (WebKit::SandboxExtension::HandleArray extensions) Async
-#endif
-
#if ENABLE(SERVICE_WORKER)
EstablishWorkerContextConnectionToNetworkProcess(WebCore::RegistrableDomain registrableDomain, PAL::SessionID sessionID) -> () Async
WorkerContextConnectionNoLongerNeeded(WebCore::ProcessIdentifier identifier)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
