Title: [256901] trunk/Source/WebCore
- Revision
- 256901
- Author
- you...@apple.com
- Date
- 2020-02-18 19:38:47 -0800 (Tue, 18 Feb 2020)
Log Message
PlatformMediaSessionClient::processingUserGestureForMedia is not needed
https://bugs.webkit.org/show_bug.cgi?id=207922
Reviewed by Eric Carlson.
All code relies on the document and the virtual method is never used so remove it.
No change of behavior.
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::processingUserGestureForMedia const): Deleted.
* Modules/mediastream/MediaStreamTrack.h:
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::processingUserGestureForMedia const): Deleted.
* Modules/webaudio/AudioContext.h:
* html/HTMLMediaElement.h:
* platform/audio/PlatformMediaSession.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (256900 => 256901)
--- trunk/Source/WebCore/ChangeLog 2020-02-19 03:26:28 UTC (rev 256900)
+++ trunk/Source/WebCore/ChangeLog 2020-02-19 03:38:47 UTC (rev 256901)
@@ -1,5 +1,24 @@
2020-02-18 Youenn Fablet <you...@apple.com>
+ PlatformMediaSessionClient::processingUserGestureForMedia is not needed
+ https://bugs.webkit.org/show_bug.cgi?id=207922
+
+ Reviewed by Eric Carlson.
+
+ All code relies on the document and the virtual method is never used so remove it.
+ No change of behavior.
+
+ * Modules/mediastream/MediaStreamTrack.cpp:
+ (WebCore::MediaStreamTrack::processingUserGestureForMedia const): Deleted.
+ * Modules/mediastream/MediaStreamTrack.h:
+ * Modules/webaudio/AudioContext.cpp:
+ (WebCore::AudioContext::processingUserGestureForMedia const): Deleted.
+ * Modules/webaudio/AudioContext.h:
+ * html/HTMLMediaElement.h:
+ * platform/audio/PlatformMediaSession.h:
+
+2020-02-18 Youenn Fablet <you...@apple.com>
+
SWServer::claim should check for the service worker to be active
https://bugs.webkit.org/show_bug.cgi?id=207739
<rdar://problem/45441129>
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp (256900 => 256901)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2020-02-19 03:26:28 UTC (rev 256900)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2020-02-19 03:38:47 UTC (rev 256901)
@@ -623,11 +623,6 @@
return m_private->type() == RealtimeMediaSource::Type::Audio && !ended() && !muted();
}
-bool MediaStreamTrack::processingUserGestureForMedia() const
-{
- return document() ? document()->processingUserGestureForMedia() : false;
-}
-
DocumentIdentifier MediaStreamTrack::hostingDocumentIdentifier() const
{
auto* document = downcast<Document>(m_scriptExecutionContext);
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h (256900 => 256901)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h 2020-02-19 03:26:28 UTC (rev 256900)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h 2020-02-19 03:38:47 UTC (rev 256901)
@@ -203,7 +203,6 @@
String sourceApplicationIdentifier() const final;
bool canProduceAudio() const final;
DocumentIdentifier hostingDocumentIdentifier() const final;
- bool processingUserGestureForMedia() const final;
bool shouldOverridePauseDuringRouteChange() const final { return true; }
#if !RELEASE_LOG_DISABLED
Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp (256900 => 256901)
--- trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp 2020-02-19 03:26:28 UTC (rev 256900)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp 2020-02-19 03:38:47 UTC (rev 256901)
@@ -382,11 +382,6 @@
return emptyString();
}
-bool AudioContext::processingUserGestureForMedia() const
-{
- return document() ? document()->processingUserGestureForMedia() : false;
-}
-
bool AudioContext::isSuspended() const
{
return !document() || document()->activeDOMObjectsAreSuspended() || document()->activeDOMObjectsAreStopped();
@@ -1098,11 +1093,12 @@
bool AudioContext::willBeginPlayback()
{
- if (!document())
+ auto* document = this->document();
+ if (!document)
return false;
if (userGestureRequiredForAudioStart()) {
- if (!processingUserGestureForMedia() && !document()->isCapturing()) {
+ if (!document->processingUserGestureForMedia() && !document->isCapturing()) {
ALWAYS_LOG(LOGIDENTIFIER, "returning false, not processing user gesture or capturing");
return false;
}
@@ -1110,9 +1106,9 @@
}
if (pageConsentRequiredForAudioStart()) {
- Page* page = document()->page();
+ auto* page = document->page();
if (page && !page->canStartMedia()) {
- document()->addMediaCanStartListener(*this);
+ document->addMediaCanStartListener(*this);
ALWAYS_LOG(LOGIDENTIFIER, "returning false, page doesn't allow media to start");
return false;
}
@@ -1127,19 +1123,20 @@
bool AudioContext::willPausePlayback()
{
- if (!document())
+ auto* document = this->document();
+ if (!document)
return false;
if (userGestureRequiredForAudioStart()) {
- if (!processingUserGestureForMedia())
+ if (!document->processingUserGestureForMedia())
return false;
removeBehaviorRestriction(AudioContext::RequireUserGestureForAudioStartRestriction);
}
if (pageConsentRequiredForAudioStart()) {
- Page* page = document()->page();
+ auto* page = document->page();
if (page && !page->canStartMedia()) {
- document()->addMediaCanStartListener(*this);
+ document->addMediaCanStartListener(*this);
return false;
}
removeBehaviorRestriction(AudioContext::RequirePageConsentForAudioStartRestriction);
Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.h (256900 => 256901)
--- trunk/Source/WebCore/Modules/webaudio/AudioContext.h 2020-02-19 03:26:28 UTC (rev 256900)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.h 2020-02-19 03:38:47 UTC (rev 256901)
@@ -359,7 +359,6 @@
String sourceApplicationIdentifier() const override;
bool canProduceAudio() const final { return true; }
bool isSuspended() const final;
- bool processingUserGestureForMedia() const final;
void visibilityStateChanged() final;
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (256900 => 256901)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2020-02-19 03:26:28 UTC (rev 256900)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2020-02-19 03:38:47 UTC (rev 256901)
@@ -891,7 +891,6 @@
bool shouldOverrideBackgroundPlaybackRestriction(PlatformMediaSession::InterruptionType) const override;
bool shouldOverrideBackgroundLoadingRestriction() const override;
bool canProduceAudio() const final;
- bool processingUserGestureForMedia() const final;
bool hasMediaStreamSource() const final;
void processIsSuspendedChanged() final;
@@ -901,6 +900,8 @@
void hardwareMutedStateDidChange(AudioSession*) final;
#endif
+ bool processingUserGestureForMedia() const;
+
bool effectiveMuted() const;
double effectiveVolume() const;
Modified: trunk/Source/WebCore/platform/audio/PlatformMediaSession.h (256900 => 256901)
--- trunk/Source/WebCore/platform/audio/PlatformMediaSession.h 2020-02-19 03:26:28 UTC (rev 256900)
+++ trunk/Source/WebCore/platform/audio/PlatformMediaSession.h 2020-02-19 03:38:47 UTC (rev 256901)
@@ -263,8 +263,6 @@
virtual DocumentIdentifier hostingDocumentIdentifier() const = 0;
virtual String sourceApplicationIdentifier() const = 0;
- virtual bool processingUserGestureForMedia() const = 0;
-
virtual bool hasMediaStreamSource() const { return false; }
virtual void processIsSuspendedChanged() { }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
