Title: [257013] trunk/Source/WebKit
Revision
257013
Author
rn...@webkit.org
Date
2020-02-19 17:50:59 -0800 (Wed, 19 Feb 2020)

Log Message

Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
https://bugs.webkit.org/show_bug.cgi?id=207973

Reviewed by Chris Dumez.

Use RefPtr to store Frame*.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (257012 => 257013)


--- trunk/Source/WebKit/ChangeLog	2020-02-20 01:27:49 UTC (rev 257012)
+++ trunk/Source/WebKit/ChangeLog	2020-02-20 01:50:59 UTC (rev 257013)
@@ -1,3 +1,15 @@
+2020-02-19  Ryosuke Niwa  <rn...@webkit.org>
+
+        Crash in WebPageProxy::didStartProvisionalLoadForFrameShared
+        https://bugs.webkit.org/show_bug.cgi?id=207973
+
+        Reviewed by Chris Dumez.
+
+        Use RefPtr to store Frame*.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
+
 2020-02-19  Ben Nham  <n...@apple.com>
 
         Avoid preconnecting to custom URL schemes

Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (257012 => 257013)


--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-02-20 01:27:49 UTC (rev 257012)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-02-20 01:50:59 UTC (rev 257013)
@@ -4272,7 +4272,7 @@
 {
     PageClientProtector protector(pageClient());
 
-    WebFrameProxy* frame = process->webFrame(frameID);
+    auto frame = makeRefPtr(process->webFrame(frameID));
     MESSAGE_CHECK(process, frame);
     MESSAGE_CHECK_URL(process, url);
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to