Title: [257609] trunk/Source/_javascript_Core
- Revision
- 257609
- Author
- sbar...@apple.com
- Date
- 2020-02-27 18:27:14 -0800 (Thu, 27 Feb 2020)
Log Message
Fix debug arm64 Wasm tests
https://bugs.webkit.org/show_bug.cgi?id=208362
Reviewed by Yusuke Suzuki.
* wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::emitChecksForModOrDiv):
We were assuming that "-1" is a valid imm on arm64, but it's not, we need
to use big imm.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (257608 => 257609)
--- trunk/Source/_javascript_Core/ChangeLog 2020-02-28 01:46:28 UTC (rev 257608)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-02-28 02:27:14 UTC (rev 257609)
@@ -1,3 +1,16 @@
+2020-02-27 Saam Barati <sbar...@apple.com>
+
+ Fix debug arm64 Wasm tests
+ https://bugs.webkit.org/show_bug.cgi?id=208362
+
+ Reviewed by Yusuke Suzuki.
+
+ * wasm/WasmAirIRGenerator.cpp:
+ (JSC::Wasm::AirIRGenerator::emitChecksForModOrDiv):
+
+ We were assuming that "-1" is a valid imm on arm64, but it's not, we need
+ to use big imm.
+
2020-02-27 Justin Michaud <justin_mich...@apple.com>
Poly proto should work with property delete transitions
Modified: trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp (257608 => 257609)
--- trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp 2020-02-28 01:46:28 UTC (rev 257608)
+++ trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp 2020-02-28 02:27:14 UTC (rev 257609)
@@ -2460,7 +2460,7 @@
append(Move, Arg::bigImm(static_cast<uint64_t>(min)), minTmp);
append(op, Arg::relCond(MacroAssembler::Equal), left, minTmp, minTmp);
- append(Move, Arg::imm(-1), negOne);
+ append(Move, Arg::isValidImmForm(-1) ? Arg::imm(-1) : Arg::bigImm(-1) , negOne);
append(op, Arg::relCond(MacroAssembler::Equal), right, negOne, negOne);
emitCheck([&] {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
