Title: [257853] trunk/Tools
- Revision
- 257853
- Author
- dba...@webkit.org
- Date
- 2020-03-04 10:06:58 -0800 (Wed, 04 Mar 2020)
Log Message
Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
https://bugs.webkit.org/show_bug.cgi?id=208564
Reviewed by Alex Christensen.
Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
to make it easy to run just these tests.
Currently, the tests are organized under the test case name WebKit. This means you need to
pass run-api-tests the name of each sub-test as there is no easy way to run them all without
also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
so that a person can run just these test using:
run-api-tests --debug TestWebKitAPI.RequestTextInputContext
* TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
(TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (257852 => 257853)
--- trunk/Tools/ChangeLog 2020-03-04 18:05:43 UTC (rev 257852)
+++ trunk/Tools/ChangeLog 2020-03-04 18:06:58 UTC (rev 257853)
@@ -1,3 +1,23 @@
+2020-03-04 Daniel Bates <daba...@apple.com>
+
+ Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
+ https://bugs.webkit.org/show_bug.cgi?id=208564
+
+ Reviewed by Alex Christensen.
+
+ Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
+ to make it easy to run just these tests.
+
+ Currently, the tests are organized under the test case name WebKit. This means you need to
+ pass run-api-tests the name of each sub-test as there is no easy way to run them all without
+ also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
+ so that a person can run just these test using:
+
+ run-api-tests --debug TestWebKitAPI.RequestTextInputContext
+
+ * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
+ (TEST):
+
2020-03-04 Aakash Jain <aakash_j...@apple.com>
[ews] Add build step to create local git commit for commit-queue
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm (257852 => 257853)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm 2020-03-04 18:05:43 UTC (rev 257852)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm 2020-03-04 18:06:58 UTC (rev 257853)
@@ -73,7 +73,7 @@
return applyStyle([NSString stringWithFormat:@"<iframe src="" style='position: absolute; top: 200px;'>", [applyStyle(HTMLString) stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLPathAllowedCharacterSet]]]);
}
-TEST(WebKit, RequestTextInputContext)
+TEST(RequestTextInputContext, Simple)
{
RetainPtr<WKWebViewConfiguration> configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
RetainPtr<TestWKWebView> webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
@@ -167,7 +167,7 @@
EXPECT_EQ(CGRectMake(0, 0, 100, 100), contexts[1].boundingRect);
}
-TEST(WebKit, DISABLED_FocusTextInputContext)
+TEST(RequestTextInputContext, DISABLED_FocusTextInputContext)
{
RetainPtr<WKWebViewConfiguration> configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
WKPreferencesSetThreadedScrollingEnabled((WKPreferencesRef)[configuration preferences], false);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
