Title: [257856] trunk/Source/_javascript_Core
- Revision
- 257856
- Author
- commit-qu...@webkit.org
- Date
- 2020-03-04 10:21:49 -0800 (Wed, 04 Mar 2020)
Log Message
JSC 32bits broken in debug mode by r257399
https://bugs.webkit.org/show_bug.cgi?id=208439
Patch by Paulo Matos <pma...@igalia.com> on 2020-03-04
Reviewed by Carlos Alberto Lopez Perez.
Use uses() method call instead of gpr() on assert to that it
works for both 64 and 32 bits.
* bytecode/AccessCase.cpp:
(JSC::AccessCase::generateImpl):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (257855 => 257856)
--- trunk/Source/_javascript_Core/ChangeLog 2020-03-04 18:21:08 UTC (rev 257855)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-03-04 18:21:49 UTC (rev 257856)
@@ -1,3 +1,16 @@
+2020-03-04 Paulo Matos <pma...@igalia.com>
+
+ JSC 32bits broken in debug mode by r257399
+ https://bugs.webkit.org/show_bug.cgi?id=208439
+
+ Reviewed by Carlos Alberto Lopez Perez.
+
+ Use uses() method call instead of gpr() on assert to that it
+ works for both 64 and 32 bits.
+
+ * bytecode/AccessCase.cpp:
+ (JSC::AccessCase::generateImpl):
+
2020-03-03 Saam Barati <sbar...@apple.com>
Refactor FixedVMPoolExecutableAllocator to not have member functions which are really just helper functions
Modified: trunk/Source/_javascript_Core/bytecode/AccessCase.cpp (257855 => 257856)
--- trunk/Source/_javascript_Core/bytecode/AccessCase.cpp 2020-03-04 18:21:08 UTC (rev 257855)
+++ trunk/Source/_javascript_Core/bytecode/AccessCase.cpp 2020-03-04 18:21:49 UTC (rev 257856)
@@ -1942,9 +1942,9 @@
allocator.lock(scratchGPR);
ASSERT(structure()->transitionWatchpointSetHasBeenInvalidated());
ASSERT(newStructure()->isPropertyDeletionTransition());
- ASSERT(baseGPR != valueRegs.gpr());
ASSERT(baseGPR != scratchGPR);
- ASSERT(valueRegs.gpr() != scratchGPR);
+ ASSERT(!valueRegs.uses(baseGPR));
+ ASSERT(!valueRegs.uses(scratchGPR));
ScratchRegisterAllocator::PreservedState preservedState =
allocator.preserveReusedRegistersByPushing(jit, ScratchRegisterAllocator::ExtraStackSpace::NoExtraSpace);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
