Title: [257894] trunk/WebDriverTests
Revision
257894
Author
lmo...@igalia.com
Date
2020-03-04 18:35:06 -0800 (Wed, 04 Mar 2020)

Log Message

[WebDriver] Update screenshot/user_prompt expectations.

They were marked as FAIL in r239824 due to upstream w3c tests not handling
dialogs correctly and this handling not being in the spec.

The correct handling was added to wpt in
https://github.com/web-platform-tests/wpt/pull/17563, imported to webkit
in r252358, and have been passing since in the GTK test bot.

Also were added to the spec in https://github.com/w3c/webdriver/commit/32165846

Unreviewed test gardening.

* TestExpectations.json:

Modified Paths

Diff

Modified: trunk/WebDriverTests/ChangeLog (257893 => 257894)


--- trunk/WebDriverTests/ChangeLog	2020-03-05 02:04:49 UTC (rev 257893)
+++ trunk/WebDriverTests/ChangeLog	2020-03-05 02:35:06 UTC (rev 257894)
@@ -1,3 +1,20 @@
+2020-03-04  Lauro Moura  <lmo...@igalia.com>
+
+        [WebDriver] Update screenshot/user_prompt expectations.
+
+        They were marked as FAIL in r239824 due to upstream w3c tests not handling
+        dialogs correctly and this handling not being in the spec.
+
+        The correct handling was added to wpt in
+        https://github.com/web-platform-tests/wpt/pull/17563, imported to webkit
+        in r252358, and have been passing since in the GTK test bot.
+
+        Also were added to the spec in https://github.com/w3c/webdriver/commit/32165846
+
+        Unreviewed test gardening.
+
+        * TestExpectations.json:
+
 2020-01-10  Carlos Garcia Campos  <cgar...@igalia.com>
 
         Automation: evaluateJavaScriptFunction should use Promises

Modified: trunk/WebDriverTests/TestExpectations.json (257893 => 257894)


--- trunk/WebDriverTests/TestExpectations.json	2020-03-05 02:04:49 UTC (rev 257893)
+++ trunk/WebDriverTests/TestExpectations.json	2020-03-05 02:35:06 UTC (rev 257894)
@@ -675,12 +675,6 @@
     "imported/w3c/webdriver/tests/permissions/set.py": {
         "expected": {"all": {"status": ["SKIP"], "bug": "webkit.org/b/192978"}}
     },
-    "imported/w3c/webdriver/tests/take_screenshot/user_prompts.py": {
-        "expected": {"all": {"status": ["FAIL"]}}
-    },
-    "imported/w3c/webdriver/tests/take_element_screenshot/user_prompts.py": {
-        "expected": {"all": {"status": ["FAIL"]}}
-    },
     "imported/w3c/webdriver/tests/switch_to_frame/cross_origin.py": {
         "subtests": {
             "test_nested_cross_origin_iframe": {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to