Title: [257965] trunk/Source/WebInspectorUI
- Revision
- 257965
- Author
- nvasil...@apple.com
- Date
- 2020-03-05 19:57:30 -0800 (Thu, 05 Mar 2020)
Log Message
Web Inspector: AXI: annotate tab panels
https://bugs.webkit.org/show_bug.cgi?id=208542
Reviewed by Devin Rousso.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/Main.js:
Remove `role=main` since it was providing very generic and not useful description to VoiceOver.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (257964 => 257965)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-03-06 03:00:01 UTC (rev 257964)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-03-06 03:57:30 UTC (rev 257965)
@@ -1,5 +1,16 @@
2020-03-05 Nikita Vasilyev <nvasil...@apple.com>
+ Web Inspector: AXI: annotate tab panels
+ https://bugs.webkit.org/show_bug.cgi?id=208542
+
+ Reviewed by Devin Rousso.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Base/Main.js:
+ Remove `role=main` since it was providing very generic and not useful description to VoiceOver.
+
+2020-03-05 Nikita Vasilyev <nvasil...@apple.com>
+
Web Inspector: AXI: can't leave Styles and Computed panels by pressing Tab
https://bugs.webkit.org/show_bug.cgi?id=208549
<rdar://problem/60020149>
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (257964 => 257965)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2020-03-06 03:00:01 UTC (rev 257964)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2020-03-06 03:57:30 UTC (rev 257965)
@@ -320,7 +320,6 @@
localizedStrings["Console opened at %s"] = "Console opened at %s";
localizedStrings["Console prompt"] = "Console prompt";
localizedStrings["Containing"] = "Containing";
-localizedStrings["Content"] = "Content";
localizedStrings["Content Security Policy violation of directive: %s"] = "Content Security Policy violation of directive: %s";
localizedStrings["Continuation Frame"] = "Continuation Frame";
localizedStrings["Continue script execution (%s or %s)"] = "Continue script execution (%s or %s)";
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (257964 => 257965)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-03-06 03:00:01 UTC (rev 257964)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-03-06 03:57:30 UTC (rev 257965)
@@ -286,8 +286,7 @@
WI.tabBar = new WI.TabBar(document.getElementById("tab-bar"));
WI._contentElement = document.getElementById("content");
- WI._contentElement.setAttribute("role", "main");
- WI._contentElement.setAttribute("aria-label", WI.UIString("Content"));
+ WI._contentElement.role = "tabpanel";
WI.clearKeyboardShortcut = new WI.KeyboardShortcut(WI.KeyboardShortcut.Modifier.CommandOrControl, "K", WI._clear);
@@ -1924,9 +1923,14 @@
WI._tabBrowserSelectedTabContentViewDidChange = function(event)
{
- if (WI.tabBar.selectedTabBarItem && WI.tabBar.selectedTabBarItem.representedObject.constructor.shouldSaveTab())
- WI._selectedTabIndexSetting.value = WI.tabBar.tabBarItems.indexOf(WI.tabBar.selectedTabBarItem);
+ let selectedTabBarItem = WI.tabBar.selectedTabBarItem;
+ if (selectedTabBarItem) {
+ WI._contentElement.ariaLabel = selectedTabBarItem.title || "";
+ if (selectedTabBarItem.representedObject.constructor.shouldSaveTab())
+ WI._selectedTabIndexSetting.value = WI.tabBar.tabBarItems.indexOf(selectedTabBarItem);
+ }
+
if (WI.doesCurrentTabSupportSplitContentBrowser()) {
if (WI._shouldRevealSpitConsoleIfSupported) {
WI._shouldRevealSpitConsoleIfSupported = false;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
