Title: [259172] trunk/Source/WebKit
- Revision
- 259172
- Author
- ddkil...@apple.com
- Date
- 2020-03-28 20:02:59 -0700 (Sat, 28 Mar 2020)
Log Message
REGRESSION (r258201): Use-after-move in UserMediaCaptureManager::Source::didFail()
<https://webkit.org/b/209711>
<rdar://problem/61018569>
Reviewed by Darin Adler.
* WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::Source::didFail):
- Use `m_errorMessage` to fix the use-after-move.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (259171 => 259172)
--- trunk/Source/WebKit/ChangeLog 2020-03-29 02:58:56 UTC (rev 259171)
+++ trunk/Source/WebKit/ChangeLog 2020-03-29 03:02:59 UTC (rev 259172)
@@ -1,3 +1,15 @@
+2020-03-28 David Kilzer <ddkil...@apple.com>
+
+ REGRESSION (r258201): Use-after-move in UserMediaCaptureManager::Source::didFail()
+ <https://webkit.org/b/209711>
+ <rdar://problem/61018569>
+
+ Reviewed by Darin Adler.
+
+ * WebProcess/cocoa/UserMediaCaptureManager.cpp:
+ (WebKit::UserMediaCaptureManager::Source::didFail):
+ - Use `m_errorMessage` to fix the use-after-move.
+
2020-03-28 Alex Christensen <achristen...@webkit.org>
REGRESSION(r257963) UI process crashes when setting navigation delegate inside navigation delegate callbacks
Modified: trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp (259171 => 259172)
--- trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp 2020-03-29 02:58:56 UTC (rev 259171)
+++ trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp 2020-03-29 03:02:59 UTC (rev 259172)
@@ -113,7 +113,7 @@
m_isReady = true;
m_errorMessage = WTFMove(errorMessage);
if (m_callback)
- m_callback(String(errorMessage));
+ m_callback(m_errorMessage);
}
void setAsReady()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
