Title: [259174] trunk/LayoutTests
- Revision
- 259174
- Author
- commit-qu...@webkit.org
- Date
- 2020-03-28 21:43:07 -0700 (Sat, 28 Mar 2020)
Log Message
Regression: fast/hidpi/image-srcset-svg-canvas-2x.html is failing consistently on iOS EWS
https://bugs.webkit.org/show_bug.cgi?id=207038
Patch by Said Abou-Hallawa <sabouhall...@apple.com> on 2020-03-28
Reviewed by Darin Adler.
Disable the canvas scaling anti-aliasing by applying the CSS property
"image-rendering: pixelated;" to the <img> and the <canvas> elements.
Avoid the SVG drawing anti-aliasing entirely by replacing the <cricle>
element by a <rect> element.
* fast/hidpi/resources/relativesrcset.svg:
* fast/hidpi/resources/srcset.svg:
* fast/hidpi/resources/srcset_100px.svg:
* fast/hidpi/resources/svg_tests.css:
(.test img, .test canvas):
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (259173 => 259174)
--- trunk/LayoutTests/ChangeLog 2020-03-29 03:07:52 UTC (rev 259173)
+++ trunk/LayoutTests/ChangeLog 2020-03-29 04:43:07 UTC (rev 259174)
@@ -1,3 +1,23 @@
+2020-03-28 Said Abou-Hallawa <sabouhall...@apple.com>
+
+ Regression: fast/hidpi/image-srcset-svg-canvas-2x.html is failing consistently on iOS EWS
+ https://bugs.webkit.org/show_bug.cgi?id=207038
+
+ Reviewed by Darin Adler.
+
+ Disable the canvas scaling anti-aliasing by applying the CSS property
+ "image-rendering: pixelated;" to the <img> and the <canvas> elements.
+
+ Avoid the SVG drawing anti-aliasing entirely by replacing the <cricle>
+ element by a <rect> element.
+
+ * fast/hidpi/resources/relativesrcset.svg:
+ * fast/hidpi/resources/srcset.svg:
+ * fast/hidpi/resources/srcset_100px.svg:
+ * fast/hidpi/resources/svg_tests.css:
+ (.test img, .test canvas):
+ * platform/mac/TestExpectations:
+
2020-03-28 Devin Rousso <drou...@apple.com>
Web Inspector: support editing cookie key/values from inspector
Modified: trunk/LayoutTests/fast/hidpi/resources/relativesrcset.svg (259173 => 259174)
--- trunk/LayoutTests/fast/hidpi/resources/relativesrcset.svg 2020-03-29 03:07:52 UTC (rev 259173)
+++ trunk/LayoutTests/fast/hidpi/resources/relativesrcset.svg 2020-03-29 04:43:07 UTC (rev 259174)
@@ -1,4 +1,4 @@
<svg xmlns='http://www.w3.org/2000/svg' width='100%' height='100%'>
<rect fill='pink' width='50%' height='100%'/>
- <circle fill='purple' cx='50' cy='25' r='15'/>
+ <rect fill='purple' x="35" y="10" width='30' height='30'/>
</svg>
\ No newline at end of file
Modified: trunk/LayoutTests/fast/hidpi/resources/srcset.svg (259173 => 259174)
--- trunk/LayoutTests/fast/hidpi/resources/srcset.svg 2020-03-29 03:07:52 UTC (rev 259173)
+++ trunk/LayoutTests/fast/hidpi/resources/srcset.svg 2020-03-29 04:43:07 UTC (rev 259174)
@@ -1,4 +1,4 @@
<svg xmlns='http://www.w3.org/2000/svg' width='200' height='100'>
<rect fill='green' width='50%' height='100%'/>
- <circle fill='blue' cx='100' cy='50' r='30'/>
+ <rect fill='blue' x="70" y="20" width='60' height='60'/>
</svg>
\ No newline at end of file
Modified: trunk/LayoutTests/fast/hidpi/resources/srcset_100px.svg (259173 => 259174)
--- trunk/LayoutTests/fast/hidpi/resources/srcset_100px.svg 2020-03-29 03:07:52 UTC (rev 259173)
+++ trunk/LayoutTests/fast/hidpi/resources/srcset_100px.svg 2020-03-29 04:43:07 UTC (rev 259174)
@@ -1,4 +1,4 @@
<svg xmlns='http://www.w3.org/2000/svg' width='100' height='50'>
<rect fill='green' width='50%' height='100%'/>
- <circle fill='blue' cx='50' cy='25' r='15'/>
+ <rect fill='blue' x="35" y="10" width='30' height='30'/>
</svg>
Modified: trunk/LayoutTests/fast/hidpi/resources/svg_tests.css (259173 => 259174)
--- trunk/LayoutTests/fast/hidpi/resources/svg_tests.css 2020-03-29 03:07:52 UTC (rev 259173)
+++ trunk/LayoutTests/fast/hidpi/resources/svg_tests.css 2020-03-29 04:43:07 UTC (rev 259174)
@@ -5,6 +5,7 @@
}
.test img, .test canvas {
border: 1px solid black;
+ image-rendering: pixelated;
}
.test .stats {
display: inline-block;
Modified: trunk/LayoutTests/platform/mac/TestExpectations (259173 => 259174)
--- trunk/LayoutTests/platform/mac/TestExpectations 2020-03-29 03:07:52 UTC (rev 259173)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2020-03-29 04:43:07 UTC (rev 259174)
@@ -628,8 +628,6 @@
# repaintRectsAsText reports different repaintrects.
webkit.org/b/131887 fast/repaint/hidpi-wrong-repaint-rect-when-parent-has-noncompositing-transform.html [ Failure ]
-webkit.org/b/124342 fast/hidpi/image-srcset-svg-canvas.html [ ImageOnlyFailure ]
-
webkit.org/b/187491 fast/hidpi/filters-and-image-buffer-resolution.html [ Pass ImageOnlyFailure ]
webkit.org/b/136419 fast/sub-pixel/block-with-margin-overflow.html [ ImageOnlyFailure ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
