Title: [259565] trunk
- Revision
- 259565
- Author
- ross.kirsl...@sony.com
- Date
- 2020-04-05 23:02:06 -0700 (Sun, 05 Apr 2020)
Log Message
DLLLauncherMain print to console instead of opening window on fatal error
https://bugs.webkit.org/show_bug.cgi?id=206537
Reviewed by Fujii Hironori.
Source/_javascript_Core:
* shell/DLLLauncherMain.cpp:
(fatalError):
Tools:
* win/DLLLauncher/DLLLauncherMain.cpp:
(fatalError):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (259564 => 259565)
--- trunk/Source/_javascript_Core/ChangeLog 2020-04-06 04:34:36 UTC (rev 259564)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-04-06 06:02:06 UTC (rev 259565)
@@ -1,3 +1,13 @@
+2020-04-05 Gus Caplan <m...@gus.host> and Ross Kirsling <ross.kirsl...@sony.com>
+
+ DLLLauncherMain print to console instead of opening window on fatal error
+ https://bugs.webkit.org/show_bug.cgi?id=206537
+
+ Reviewed by Fujii Hironori.
+
+ * shell/DLLLauncherMain.cpp:
+ (fatalError):
+
2020-04-05 Ross Kirsling <ross.kirsl...@sony.com>
JSC shell shouldn't treat NUL as a terminator when printing a JS string
Modified: trunk/Source/_javascript_Core/shell/DLLLauncherMain.cpp (259564 => 259565)
--- trunk/Source/_javascript_Core/shell/DLLLauncherMain.cpp 2020-04-06 04:34:36 UTC (rev 259564)
+++ trunk/Source/_javascript_Core/shell/DLLLauncherMain.cpp 2020-04-06 06:02:06 UTC (rev 259565)
@@ -94,7 +94,11 @@
static int fatalError(const std::wstring& programName, const std::wstring& message)
{
std::wstring caption = programName + L" can't open.";
+#if USE_CONSOLE_ENTRY_POINT
+ fwprintf(stderr, L"%s\n%s\n", caption.c_str(), message.c_str());
+#else
::MessageBoxW(0, message.c_str(), caption.c_str(), MB_ICONERROR);
+#endif
return 1;
}
Modified: trunk/Tools/ChangeLog (259564 => 259565)
--- trunk/Tools/ChangeLog 2020-04-06 04:34:36 UTC (rev 259564)
+++ trunk/Tools/ChangeLog 2020-04-06 06:02:06 UTC (rev 259565)
@@ -1,3 +1,13 @@
+2020-04-05 Gus Caplan <m...@gus.host> and Ross Kirsling <ross.kirsl...@sony.com>
+
+ DLLLauncherMain print to console instead of opening window on fatal error
+ https://bugs.webkit.org/show_bug.cgi?id=206537
+
+ Reviewed by Fujii Hironori.
+
+ * win/DLLLauncher/DLLLauncherMain.cpp:
+ (fatalError):
+
2020-04-05 Don Olmstead <don.olmst...@sony.com>
[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
Modified: trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp (259564 => 259565)
--- trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp 2020-04-06 04:34:36 UTC (rev 259564)
+++ trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp 2020-04-06 06:02:06 UTC (rev 259565)
@@ -96,7 +96,11 @@
static int fatalError(const wstring& programName, const wstring& message)
{
wstring caption = programName + L" can't open.";
+#if USE_CONSOLE_ENTRY_POINT
+ fwprintf(stderr, L"%s\n%s\n", caption.c_str(), message.c_str());
+#else
::MessageBoxW(0, message.c_str(), caption.c_str(), MB_ICONERROR);
+#endif
return 1;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
