Title: [260120] trunk/Source/WebKit
- Revision
- 260120
- Author
- s...@apple.com
- Date
- 2020-04-15 01:53:39 -0700 (Wed, 15 Apr 2020)
Log Message
Unreviewed, reverting r259891.
Causes significant iOS MotionMark regression
Reverted changeset:
"Switch unused IOKit classes from allow-with-report to deny-
with-report"
https://bugs.webkit.org/show_bug.cgi?id=210136
https://trac.webkit.org/changeset/259891
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (260119 => 260120)
--- trunk/Source/WebKit/ChangeLog 2020-04-15 07:02:55 UTC (rev 260119)
+++ trunk/Source/WebKit/ChangeLog 2020-04-15 08:53:39 UTC (rev 260120)
@@ -1,3 +1,16 @@
+2020-04-15 Said Abou-Hallawa <sabouhall...@apple.com>
+
+ Unreviewed, reverting r259891.
+
+ Causes significant iOS MotionMark regression
+
+ Reverted changeset:
+
+ "Switch unused IOKit classes from allow-with-report to deny-
+ with-report"
+ https://bugs.webkit.org/show_bug.cgi?id=210136
+ https://trac.webkit.org/changeset/259891
+
2020-04-14 Megan Gardner <megan_gard...@apple.com>
File Upload Menus presented from odd locations.
Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (260119 => 260120)
--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2020-04-15 07:02:55 UTC (rev 260119)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2020-04-15 08:53:39 UTC (rev 260120)
@@ -214,7 +214,7 @@
;;;
(define-once (opengl)
;; Items not seen in testing
- (deny iokit-open (with telemetry-backtrace)
+ (allow iokit-open (with report) (with telemetry)
(iokit-connection "IOGPU")
(iokit-user-client-class
"AGXCommandQueue"
@@ -374,7 +374,9 @@
(allow mach-lookup
(global-name "com.apple.CARenderServer"))
- (deny iokit-open (with telemetry-backtrace)
+ ; UIKit-required IOKit nodes.
+ (allow iokit-open (with report) (with telemetry)
+ (iokit-user-client-class "AppleJPEGDriverUserClient")
(iokit-user-client-class "IOSurfaceSendRight")
)
Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (260119 => 260120)
--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-04-15 07:02:55 UTC (rev 260119)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-04-15 08:53:39 UTC (rev 260120)
@@ -120,13 +120,17 @@
(iokit-registry-entry-class "IOAccelerationUserClient")
(iokit-registry-entry-class "IOSurfaceRootUserClient")
(iokit-registry-entry-class "IOSurfaceSendRight"))
-#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101600
;; CoreVideo CVCGDisplayLink
(allow iokit-open
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
+ (with report) (with telemetry)
+#endif
(iokit-registry-entry-class "IOFramebufferSharedUserClient"))
-#endif
;; H.264 Acceleration
(allow iokit-open
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
+ (with report) (with telemetry)
+#endif
(iokit-registry-entry-class "AppleIntelMEUserClient")
(iokit-registry-entry-class "AppleSNBFBUserClient"))
;; QuartzCore
@@ -600,30 +604,20 @@
(allow-read-write-directory-and-issue-read-write-extensions (param "DARWIN_USER_TEMP_DIR")))
;; IOKit user clients
-#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101600
(allow iokit-open
- (iokit-user-client-class "AppleMultitouchDeviceUserClient")
- (iokit-user-client-class "IOHIDParamUserClient")
- (iokit-user-client-class "IOAudioControlUserClient")
- (iokit-user-client-class "IOAudioEngineUserClient")
-)
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
+ (with report) (with telemetry)
#endif
-
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600
-(deny iokit-open
- (with send-signal SIGKILL)
(iokit-user-client-class "AppleMultitouchDeviceUserClient")
(iokit-user-client-class "IOHIDParamUserClient")
(iokit-user-client-class "IOAudioControlUserClient")
(iokit-user-client-class "IOAudioEngineUserClient")
- (iokit-registry-entry-class "IOFramebufferSharedUserClient")
-)
-#endif
+ ;; Following is needed due to <rdar://problem/10427451> && <rdar://problem/10808817>
+ (iokit-user-client-class "AudioAUUC"))
(allow iokit-open
(iokit-user-client-class "AppleUpstreamUserClient")
(iokit-user-client-class "RootDomainUserClient") ;; Needed by WebCore::PerformanceMonitor
- (iokit-user-client-class "AudioAUUC") ;; <rdar://problem/10427451> && <rdar://problem/10808817>
)
;; cookied.
@@ -723,9 +717,6 @@
;; Needed to support encrypted media playback <rdar://problem/40038478>
(allow mach-lookup
-#if __MAC_OS_X_VERSION_MIN_REQUIRED > 101500
- (with telemetry-backtrace)
-#endif
(global-name "com.apple.SecurityServer")
(global-name "com.apple.ocspd"))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
