Title: [260154] trunk/LayoutTests
Revision
260154
Author
shihchieh_...@apple.com
Date
2020-04-15 15:01:51 -0700 (Wed, 15 Apr 2020)

Log Message

Infinite loop in InsertListCommand::doApply()
https://bugs.webkit.org/show_bug.cgi?id=210354
<rdar://problem/61427778>

Reviewed by Geoffrey Garen.

Update the regression test for this hang issue.

* editing/inserting/insert-list-end-of-table-expected.txt: Added.
* editing/inserting/insert-list-end-of-table.html: Added.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (260153 => 260154)


--- trunk/LayoutTests/ChangeLog	2020-04-15 21:57:22 UTC (rev 260153)
+++ trunk/LayoutTests/ChangeLog	2020-04-15 22:01:51 UTC (rev 260154)
@@ -1,5 +1,18 @@
 2020-04-15  Jack Lee  <shihchieh_...@apple.com>
 
+        Infinite loop in InsertListCommand::doApply()
+        https://bugs.webkit.org/show_bug.cgi?id=210354
+        <rdar://problem/61427778>
+
+        Reviewed by Geoffrey Garen.
+
+        Update the regression test for this hang issue.
+
+        * editing/inserting/insert-list-end-of-table-expected.txt: Added.
+        * editing/inserting/insert-list-end-of-table.html: Added.
+
+2020-04-15  Jack Lee  <shihchieh_...@apple.com>
+
         ASSERTION FAILED: !selectionToDelete.isNone() in TypingCommand::forwardDeleteKeyPressed 
         when deleting a UserSelect::None element.
         https://bugs.webkit.org/show_bug.cgi?id=210530

Modified: trunk/LayoutTests/editing/inserting/insert-list-end-of-table.html (260153 => 260154)


--- trunk/LayoutTests/editing/inserting/insert-list-end-of-table.html	2020-04-15 21:57:22 UTC (rev 260153)
+++ trunk/LayoutTests/editing/inserting/insert-list-end-of-table.html	2020-04-15 22:01:51 UTC (rev 260154)
@@ -1,18 +1,10 @@
+<body contenteditable="true"><input id=input><table><td id=td>content</td></table></body>
 <script>
-    if (window.testRunner) {
-        testRunner.dumpAsText();
-        testRunner.waitUntilDone();
-    }
-
-    window._onload_ = () => {
-        window.getSelection().setBaseAndExtent(TH,1,SPAN,0);
-        document.execCommand("insertUnorderedList", false);
-
-        requestAnimationFrame(function () {
-            document.body.innerHTML = "<p> Tests inserting list at the end of a table. The test passes if WebKit doesn't crash or hit an assertion.</p>";
-            if (window.testRunner)
-                testRunner.notifyDone();
-        });
-    }
+document.body.offsetHeight;
+window.getSelection().setBaseAndExtent(td, 1, input, 0);
+document.execCommand("insertUnorderedList", false);
+document.body.offsetHeight;
+document.body.innerText = "Tests inserting list at the end of a table. The test passes if WebKit doesn't crash or hit an assertion.";
+if (window.testRunner)
+  testRunner.dumpAsText();
 </script>
-<body contenteditable="true"><table><select></select><th id=TH>a</th><span id=SPAN></span></table></body>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to