Title: [260761] trunk/Source/WebInspectorUI
- Revision
- 260761
- Author
- nvasil...@apple.com
- Date
- 2020-04-27 09:31:30 -0700 (Mon, 27 Apr 2020)
Log Message
REGRESSION (r258730): Web Inspector: Sidebar tabs have incorrect tabIndex
https://bugs.webkit.org/show_bug.cgi?id=211072
<rdar://problem/62445067>
Reviewed by Brian Burg.
Only selected radio button should be focusable. This matches native macOS radio buttons.
* UserInterface/Views/RadioButtonNavigationItem.js:
(WI.RadioButtonNavigationItem.prototype.get tabbable):
This getter was incorrectly returning -1 or 0 instead of a boolean value.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (260760 => 260761)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-04-27 16:18:09 UTC (rev 260760)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-04-27 16:31:30 UTC (rev 260761)
@@ -1,3 +1,17 @@
+2020-04-27 Nikita Vasilyev <nvasil...@apple.com>
+
+ REGRESSION (r258730): Web Inspector: Sidebar tabs have incorrect tabIndex
+ https://bugs.webkit.org/show_bug.cgi?id=211072
+ <rdar://problem/62445067>
+
+ Reviewed by Brian Burg.
+
+ Only selected radio button should be focusable. This matches native macOS radio buttons.
+
+ * UserInterface/Views/RadioButtonNavigationItem.js:
+ (WI.RadioButtonNavigationItem.prototype.get tabbable):
+ This getter was incorrectly returning -1 or 0 instead of a boolean value.
+
2020-04-27 Diego Pino Garcia <dp...@igalia.com>
Unreviewed, reverting r260672.
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RadioButtonNavigationItem.js (260760 => 260761)
--- trunk/Source/WebInspectorUI/UserInterface/Views/RadioButtonNavigationItem.js 2020-04-27 16:18:09 UTC (rev 260760)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RadioButtonNavigationItem.js 2020-04-27 16:31:30 UTC (rev 260761)
@@ -69,7 +69,7 @@
get tabbable()
{
- return this.selected ? 0 : -1;
+ return this.selected;
}
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
