Title: [261282] trunk
- Revision
- 261282
- Author
- ph...@webkit.org
- Date
- 2020-05-07 06:42:41 -0700 (Thu, 07 May 2020)
Log Message
[GTK] Test failures after Flatpak upgrade
https://bugs.webkit.org/show_bug.cgi?id=211497
Reviewed by Adrian Perez de Castro.
Tools:
* flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox): Don't set WEBKIT_TOP_LEVEL. I'm
not sure why it's needed at all. If it needs to be set it should
be /app/webkit/ anyway. Setting it to /app triggers test failures
due to invalid computed paths by internals' pathToLocalResource().
LayoutTests:
* platform/gtk/TestExpectations: Unflag fixed tests. The webgl
failures seem more related to bug #211338 actually.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (261281 => 261282)
--- trunk/LayoutTests/ChangeLog 2020-05-07 13:12:30 UTC (rev 261281)
+++ trunk/LayoutTests/ChangeLog 2020-05-07 13:42:41 UTC (rev 261282)
@@ -1,3 +1,13 @@
+2020-05-07 Philippe Normand <pnorm...@igalia.com>
+
+ [GTK] Test failures after Flatpak upgrade
+ https://bugs.webkit.org/show_bug.cgi?id=211497
+
+ Reviewed by Adrian Perez de Castro.
+
+ * platform/gtk/TestExpectations: Unflag fixed tests. The webgl
+ failures seem more related to bug #211338 actually.
+
2020-05-07 Diego Pino Garcia <dp...@igalia.com>
[GTK] Gardening, update baselines after r261248
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (261281 => 261282)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2020-05-07 13:12:30 UTC (rev 261281)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-05-07 13:42:41 UTC (rev 261282)
@@ -1495,16 +1495,11 @@
webkit.org/b/211338 webgl/1.0.3/conformance/textures/tex-sub-image-2d.html [ Failure ]
webkit.org/b/211338 webgl/1.0.3/conformance/textures/texture-sub-image-cube-maps.html [ Failure ]
webkit.org/b/211338 webgl/1.0.3/conformance/textures/texture-upload-cube-maps.html [ Failure ]
+webkit.org/b/211338 webgl/1.0.3/conformance/glsl/bugs/sampler-array-using-loop-index.html [ Failure ]
+webkit.org/b/211338 webgl/1.0.3/conformance/textures/texture-size-limit.html [ Failure ]
webkit.org/b/210239 fast/canvas/webgl/index-validation-with-subsequent-draws.html [ Failure ]
-webkit.org/b/211497 fast/loader/local-CSS-from-local.html [ Failure ]
-webkit.org/b/211497 fast/loader/local-_javascript_-from-local.html [ Failure ]
-webkit.org/b/211497 fast/loader/local-image-from-local.html [ Failure ]
-webkit.org/b/211497 http/tests/security/local-user-CSS-from-remote.html [ Failure ]
-webkit.org/b/211497 webgl/1.0.3/conformance/glsl/bugs/sampler-array-using-loop-index.html [ Failure ]
-webkit.org/b/211497 webgl/1.0.3/conformance/textures/texture-size-limit.html [ Failure ]
-
webkit.org/b/211501 compositing/iframes/border-radius-composited-frame.html [ ImageOnlyFailure ]
webkit.org/b/211501 compositing/iframes/border-uneven-radius-composited-frame.html [ ImageOnlyFailure ]
@@ -4293,8 +4288,7 @@
webkit.org/b/183611 webkit.org/b/198830 media/context-menu-actions.html [ Failure Crash ]
-# Started to timeout in 211497.
-webkit.org/b/183902 webkit.org/b/211497 fast/dom/frame-loading-via-document-write.html [ Failure Timeout ]
+webkit.org/b/183902 fast/dom/frame-loading-via-document-write.html [ Failure ]
webkit.org/b/184504 imported/w3c/web-platform-tests/fetch/api/request/request-keepalive-quota.html [ Failure ]
Modified: trunk/Tools/ChangeLog (261281 => 261282)
--- trunk/Tools/ChangeLog 2020-05-07 13:12:30 UTC (rev 261281)
+++ trunk/Tools/ChangeLog 2020-05-07 13:42:41 UTC (rev 261282)
@@ -1,3 +1,16 @@
+2020-05-07 Philippe Normand <pnorm...@igalia.com>
+
+ [GTK] Test failures after Flatpak upgrade
+ https://bugs.webkit.org/show_bug.cgi?id=211497
+
+ Reviewed by Adrian Perez de Castro.
+
+ * flatpak/flatpakutils.py:
+ (WebkitFlatpak.run_in_sandbox): Don't set WEBKIT_TOP_LEVEL. I'm
+ not sure why it's needed at all. If it needs to be set it should
+ be /app/webkit/ anyway. Setting it to /app triggers test failures
+ due to invalid computed paths by internals' pathToLocalResource().
+
2020-05-07 Carlos Garcia Campos <cgar...@igalia.com>
Unreviewed. Fix GTK4 build with current GTK
Modified: trunk/Tools/flatpak/flatpakutils.py (261281 => 261282)
--- trunk/Tools/flatpak/flatpakutils.py 2020-05-07 13:12:30 UTC (rev 261281)
+++ trunk/Tools/flatpak/flatpakutils.py 2020-05-07 13:42:41 UTC (rev 261282)
@@ -619,7 +619,6 @@
sandbox_build_path = os.path.join(self.sandbox_source_root, "WebKitBuild", self.build_type)
sandbox_environment = {
- "WEBKIT_TOP_LEVEL": "/app/",
"TEST_RUNNER_INJECTED_BUNDLE_FILENAME": os.path.join(sandbox_build_path, "lib/libTestRunnerInjectedBundle.so"),
}
@@ -628,8 +627,6 @@
command = os.path.normpath(os.path.abspath(args[0]))
# Take into account the fact that the webkit source dir is remounted inside the sandbox.
args[0] = command.replace(self.source_root, self.sandbox_source_root)
- if args[0].endswith("build-webkit"):
- args.append("--prefix=/app")
if args[0] == "bash":
args.extend(['--noprofile', '--norc', '-i'])
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
