Diff
Modified: trunk/Source/WebCore/ChangeLog (263269 => 263270)
--- trunk/Source/WebCore/ChangeLog 2020-06-19 16:18:43 UTC (rev 263269)
+++ trunk/Source/WebCore/ChangeLog 2020-06-19 16:21:49 UTC (rev 263270)
@@ -1,3 +1,21 @@
+2020-06-19 Chris Dumez <cdu...@apple.com>
+
+ Move Prefixed WebAudio interfaces behind their own feature flag
+ https://bugs.webkit.org/show_bug.cgi?id=213356
+
+ Reviewed by Darin Adler.
+
+ Move Prefixed WebAudio interfaces behind their own feature flag, on by default. This will
+ allow us to easily disable the prefixed API and will also allow it to live independently
+ from the unprefixed API.
+
+ * Modules/webaudio/AudioContext.idl:
+ * Modules/webaudio/WebKitAudioContext.idl:
+ * Modules/webaudio/WebKitAudioPannerNode.idl:
+ * Modules/webaudio/WebKitOfflineAudioContext.idl:
+ * bindings/js/WebCoreBuiltinNames.h:
+ * page/Settings.yaml:
+
2020-06-19 Zalan Bujtas <za...@apple.com>
[LFC][TFC] Do not special-case empty tables
Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.idl (263269 => 263270)
--- trunk/Source/WebCore/Modules/webaudio/AudioContext.idl 2020-06-19 16:18:43 UTC (rev 263269)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.idl 2020-06-19 16:21:49 UTC (rev 263270)
@@ -26,7 +26,7 @@
[
ActiveDOMObject,
Conditional=WEB_AUDIO,
- EnabledBySetting=ModernUnprefixedWebAudio,
+ EnabledBySetting=WebAudio&ModernUnprefixedWebAudio,
ExportMacro=WEBCORE_EXPORT,
] interface AudioContext : EventTarget {
[CallWith=Document, MayThrowException] constructor();
Modified: trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.idl (263269 => 263270)
--- trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.idl 2020-06-19 16:18:43 UTC (rev 263269)
+++ trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.idl 2020-06-19 16:21:49 UTC (rev 263270)
@@ -26,7 +26,7 @@
[
ActiveDOMObject,
Conditional=WEB_AUDIO,
- EnabledBySetting=WebAudio,
+ EnabledBySetting=WebAudio&PrefixedWebAudio,
ExportMacro=WEBCORE_EXPORT,
InterfaceName=webkitAudioContext,
] interface WebKitAudioContext : EventTarget {
Modified: trunk/Source/WebCore/Modules/webaudio/WebKitAudioPannerNode.idl (263269 => 263270)
--- trunk/Source/WebCore/Modules/webaudio/WebKitAudioPannerNode.idl 2020-06-19 16:18:43 UTC (rev 263269)
+++ trunk/Source/WebCore/Modules/webaudio/WebKitAudioPannerNode.idl 2020-06-19 16:21:49 UTC (rev 263270)
@@ -24,6 +24,7 @@
[
Conditional=WEB_AUDIO,
+ EnabledBySetting=PrefixedWebAudio,
JSGenerateToJSObject,
InterfaceName=webkitAudioPannerNode,
] interface WebKitAudioPannerNode : AudioNode {
Modified: trunk/Source/WebCore/Modules/webaudio/WebKitOfflineAudioContext.idl (263269 => 263270)
--- trunk/Source/WebCore/Modules/webaudio/WebKitOfflineAudioContext.idl 2020-06-19 16:18:43 UTC (rev 263269)
+++ trunk/Source/WebCore/Modules/webaudio/WebKitOfflineAudioContext.idl 2020-06-19 16:21:49 UTC (rev 263270)
@@ -24,6 +24,7 @@
[
Conditional=WEB_AUDIO,
+ EnabledBySetting=PrefixedWebAudio,
InterfaceName=webkitOfflineAudioContext,
JSGenerateToJSObject,
] interface WebKitOfflineAudioContext : WebKitAudioContext {
Modified: trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h (263269 => 263270)
--- trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h 2020-06-19 16:18:43 UTC (rev 263269)
+++ trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h 2020-06-19 16:21:49 UTC (rev 263270)
@@ -388,6 +388,7 @@
macro(visualViewport) \
macro(webkit) \
macro(webkitAudioContext) \
+ macro(webkitAudioPannerNode) \
macro(webkitIDBCursor) \
macro(webkitIDBDatabase) \
macro(webkitIDBFactory) \
@@ -397,6 +398,7 @@
macro(webkitIDBRequest) \
macro(webkitIDBTransaction) \
macro(webkitIndexedDB) \
+ macro(webkitOfflineAudioContext) \
macro(window) \
macro(writing) \
WEBCORE_ADDITIONAL_PRIVATE_IDENTIFIERS(macro) \
Modified: trunk/Source/WebCore/page/Settings.yaml (263269 => 263270)
--- trunk/Source/WebCore/page/Settings.yaml 2020-06-19 16:18:43 UTC (rev 263269)
+++ trunk/Source/WebCore/page/Settings.yaml 2020-06-19 16:21:49 UTC (rev 263270)
@@ -255,6 +255,8 @@
initial: true
webAudioEnabled:
initial: false
+prefixedWebAudioEnabled:
+ initial: false
modernUnprefixedWebAudioEnabled:
initial: false
paginateDuringLayoutEnabled:
Modified: trunk/Source/WebKit/ChangeLog (263269 => 263270)
--- trunk/Source/WebKit/ChangeLog 2020-06-19 16:18:43 UTC (rev 263269)
+++ trunk/Source/WebKit/ChangeLog 2020-06-19 16:21:49 UTC (rev 263270)
@@ -1,3 +1,12 @@
+2020-06-19 Chris Dumez <cdu...@apple.com>
+
+ Move Prefixed WebAudio interfaces behind their own feature flag
+ https://bugs.webkit.org/show_bug.cgi?id=213356
+
+ Reviewed by Darin Adler.
+
+ * Shared/WebPreferences.yaml:
+
2020-06-19 Rob Buis <rb...@igalia.com>
Enable stale-while-revalidate support by default
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (263269 => 263270)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-06-19 16:18:43 UTC (rev 263269)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-06-19 16:21:49 UTC (rev 263270)
@@ -334,6 +334,14 @@
defaultValue: true
condition: ENABLE(WEB_AUDIO)
+PrefixedWebAudioEnabled:
+ type: bool
+ defaultValue: true
+ condition: ENABLE(WEB_AUDIO)
+ humanReadableName: "Prefixed WebAudio API"
+ humanReadableDescription: "Prefixed WebAudio API"
+ category: internal
+
ModernUnprefixedWebAudioEnabled:
type: bool
defaultValue: false
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (263269 => 263270)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-06-19 16:18:43 UTC (rev 263269)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-06-19 16:21:49 UTC (rev 263270)
@@ -1,3 +1,13 @@
+2020-06-19 Chris Dumez <cdu...@apple.com>
+
+ Move Prefixed WebAudio interfaces behind their own feature flag
+ https://bugs.webkit.org/show_bug.cgi?id=213356
+
+ Reviewed by Darin Adler.
+
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
2020-06-15 Alex Christensen <achristen...@webkit.org>
Provide alternatively-named SPI for user style sheets and scripts
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (263269 => 263270)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-06-19 16:18:43 UTC (rev 263269)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-06-19 16:21:49 UTC (rev 263270)
@@ -3267,6 +3267,7 @@
#if ENABLE(WEB_AUDIO)
settings.setWebAudioEnabled([preferences webAudioEnabled]);
+ settings.setPrefixedWebAudioEnabled([preferences webAudioEnabled]);
settings.setModernUnprefixedWebAudioEnabled([preferences modernUnprefixedWebAudioEnabled]);
#endif
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (263269 => 263270)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2020-06-19 16:18:43 UTC (rev 263269)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2020-06-19 16:21:49 UTC (rev 263270)
@@ -1,3 +1,13 @@
+2020-06-19 Chris Dumez <cdu...@apple.com>
+
+ Move Prefixed WebAudio interfaces behind their own feature flag
+ https://bugs.webkit.org/show_bug.cgi?id=213356
+
+ Reviewed by Darin Adler.
+
+ * WebView.cpp:
+ (WebView::notifyPreferencesChanged):
+
2020-06-11 David Kilzer <ddkil...@apple.com>
[IPC] Adopt enum class for DragSourceAction
Modified: trunk/Source/WebKitLegacy/win/WebView.cpp (263269 => 263270)
--- trunk/Source/WebKitLegacy/win/WebView.cpp 2020-06-19 16:18:43 UTC (rev 263269)
+++ trunk/Source/WebKitLegacy/win/WebView.cpp 2020-06-19 16:21:49 UTC (rev 263270)
@@ -5556,6 +5556,7 @@
#if ENABLE(WEB_AUDIO)
settings.setWebAudioEnabled(true);
+ settings.setPrefixedWebAudioEnabled(true);
hr = prefsPrivate->modernUnprefixedWebAudioEnabled(&enabled);
if (FAILED(hr))
