Title: [263557] trunk/Tools
- Revision
- 263557
- Author
- clo...@igalia.com
- Date
- 2020-06-26 07:44:38 -0700 (Fri, 26 Jun 2020)
Log Message
generate-jsc-bundle should fail if passed an invalid remote-config-file parameter
https://bugs.webkit.org/show_bug.cgi?id=213615
Reviewed by Žan Doberšek.
Raise an exception if the parameter passed as remote-config-file is not a file.
* Scripts/generate-jsc-bundle:
(main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (263556 => 263557)
--- trunk/Tools/ChangeLog 2020-06-26 13:36:43 UTC (rev 263556)
+++ trunk/Tools/ChangeLog 2020-06-26 14:44:38 UTC (rev 263557)
@@ -1,3 +1,15 @@
+2020-06-26 Carlos Alberto Lopez Perez <clo...@igalia.com>
+
+ generate-jsc-bundle should fail if passed an invalid remote-config-file parameter
+ https://bugs.webkit.org/show_bug.cgi?id=213615
+
+ Reviewed by Žan Doberšek.
+
+ Raise an exception if the parameter passed as remote-config-file is not a file.
+
+ * Scripts/generate-jsc-bundle:
+ (main):
+
2020-06-26 Takashi Komori <takashi.kom...@sony.com>
Add myself to contributors.json
Modified: trunk/Tools/Scripts/generate-jsc-bundle (263556 => 263557)
--- trunk/Tools/Scripts/generate-jsc-bundle 2020-06-26 13:36:43 UTC (rev 263556)
+++ trunk/Tools/Scripts/generate-jsc-bundle 2020-06-26 14:44:38 UTC (rev 263557)
@@ -239,7 +239,9 @@
bundleFilePath = createJSCBundle(configuration, options.revision, options.buildername, platform)
print('Bundle file created at: %s' % bundleFilePath)
- if options.remoteConfigFile is not None and os.path.isfile(options.remoteConfigFile):
+ if options.remoteConfigFile is not None:
+ if not os.path.isfile(options.remoteConfigFile):
+ raise ValueError("Can't find remote config file for upload at path %s" % options.remoteConfigFile)
return uploadJSCBundle(bundleFilePath, options.remoteConfigFile, options.configuration, options.revision)
return 0
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
