Log Message
[GTK][MiniBrowser] occasional crashes when closing while download in progress https://bugs.webkit.org/show_bug.cgi?id=214007
Reviewed by Carlos Garcia Campos. Remove signal handlers from WebKitDownload when BrowserDownload is finalized, WebKitDownload may emit a signal after the UI item has been destroyed which leads to a crash. * MiniBrowser/gtk/BrowserDownloadsBar.c: (browserDownloadFinalize):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (264010 => 264011)
--- trunk/Tools/ChangeLog 2020-07-07 04:44:17 UTC (rev 264010)
+++ trunk/Tools/ChangeLog 2020-07-07 07:21:16 UTC (rev 264011)
@@ -1,3 +1,17 @@
+2020-07-07 Yury Semikhatsky <yu...@chromium.org>
+
+ [GTK][MiniBrowser] occasional crashes when closing while download in progress
+ https://bugs.webkit.org/show_bug.cgi?id=214007
+
+ Reviewed by Carlos Garcia Campos.
+
+ Remove signal handlers from WebKitDownload when BrowserDownload is finalized,
+ WebKitDownload may emit a signal after the UI item has been destroyed which leads
+ to a crash.
+
+ * MiniBrowser/gtk/BrowserDownloadsBar.c:
+ (browserDownloadFinalize):
+
2020-07-06 Wenson Hsieh <wenson_hs...@apple.com>
Web process sometimes crashes when translating an article on spiegel.de
Modified: trunk/Tools/MiniBrowser/gtk/BrowserDownloadsBar.c (264010 => 264011)
--- trunk/Tools/MiniBrowser/gtk/BrowserDownloadsBar.c 2020-07-07 04:44:17 UTC (rev 264010)
+++ trunk/Tools/MiniBrowser/gtk/BrowserDownloadsBar.c 2020-07-07 07:21:16 UTC (rev 264011)
@@ -127,6 +127,7 @@
BrowserDownload *browserDownload = BROWSER_DOWNLOAD(object);
if (browserDownload->download) {
+ g_signal_handlers_disconnect_by_data(browserDownload->download, browserDownload);
g_object_unref(browserDownload->download);
browserDownload->download = NULL;
}
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
