Title: [265339] trunk/Source/WebKit
- Revision
- 265339
- Author
- jer.no...@apple.com
- Date
- 2020-08-06 11:30:45 -0700 (Thu, 06 Aug 2020)
Log Message
[Mac,WK2] REGRESSION(r262322): ScreenTime overlay is hidden in fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=215222
<rdar://problem/65871844>
Reviewed by Eric Carlson.
During a refactor, a call to -[NSWindow setAutodisplay:YES] was dropped (in addition to a call to
NSEnableScreenUpdates(), but that has a 1s timeout so its effects aren't persistent). This meant
all NSViews added to that window need -display called on them explicitly in order to paint, and
so subviews like the ScreenTime overlay is never drawn.
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (265338 => 265339)
--- trunk/Source/WebKit/ChangeLog 2020-08-06 18:03:01 UTC (rev 265338)
+++ trunk/Source/WebKit/ChangeLog 2020-08-06 18:30:45 UTC (rev 265339)
@@ -1,3 +1,19 @@
+2020-08-06 Jer Noble <jer.no...@apple.com>
+
+ [Mac,WK2] REGRESSION(r262322): ScreenTime overlay is hidden in fullscreen mode
+ https://bugs.webkit.org/show_bug.cgi?id=215222
+ <rdar://problem/65871844>
+
+ Reviewed by Eric Carlson.
+
+ During a refactor, a call to -[NSWindow setAutodisplay:YES] was dropped (in addition to a call to
+ NSEnableScreenUpdates(), but that has a 1s timeout so its effects aren't persistent). This meant
+ all NSViews added to that window need -display called on them explicitly in order to paint, and
+ so subviews like the ScreenTime overlay is never drawn.
+
+ * UIProcess/mac/WKFullScreenWindowController.mm:
+ (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
+
2020-08-06 Truitt Savell <tsav...@apple.com>
Unreviewed, reverting r265328.
Modified: trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm (265338 => 265339)
--- trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm 2020-08-06 18:03:01 UTC (rev 265338)
+++ trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm 2020-08-06 18:30:45 UTC (rev 265339)
@@ -337,7 +337,13 @@
[window makeFirstResponder:_webView];
_page->setSuppressVisibilityUpdates(false);
+ ALLOW_DEPRECATED_DECLARATIONS_BEGIN
+ [[self window] setAutodisplay:YES];
+ ALLOW_DEPRECATED_DECLARATIONS_END
[[self window] displayIfNeeded];
+ ALLOW_DEPRECATED_DECLARATIONS_BEGIN
+ NSEnableScreenUpdates();
+ ALLOW_DEPRECATED_DECLARATIONS_END
[CATransaction commit];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
