Title: [265356] trunk/Source/WebInspectorUI
- Revision
- 265356
- Author
- nvasil...@apple.com
- Date
- 2020-08-06 17:19:15 -0700 (Thu, 06 Aug 2020)
Log Message
Web Inspector: Media & Animations timeline shouldn't shift when sorting
https://bugs.webkit.org/show_bug.cgi?id=215085
Reviewed by Devin Rousso.
* UserInterface/Views/DataGrid.css:
(.data-grid):
(.data-grid th):
(.data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after):
* UserInterface/Views/TimelineDataGrid.css:
(.data-grid.timeline th.graph-column > .timeline-ruler):
Override padding defined in `.data-grid th > .header-cell-content`.
(.data-grid.timeline th > .header-cell-content.timeline-ruler > .markers):
(.data-grid.timeline th:matches(.sort-ascending, .sort-descending) > .header-cell-content.timeline-ruler:first-child::after):
`.header-cell-content.timeline-ruler` is different from `.header-cell-content` in the sense that the former takes the entire
height of DataGrid and has no padding. Place the chevron in the middle of `--data-grid-header-height`.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (265355 => 265356)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-08-07 00:00:54 UTC (rev 265355)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-08-07 00:19:15 UTC (rev 265356)
@@ -1,3 +1,23 @@
+2020-08-06 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: Media & Animations timeline shouldn't shift when sorting
+ https://bugs.webkit.org/show_bug.cgi?id=215085
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/DataGrid.css:
+ (.data-grid):
+ (.data-grid th):
+ (.data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after):
+ * UserInterface/Views/TimelineDataGrid.css:
+ (.data-grid.timeline th.graph-column > .timeline-ruler):
+ Override padding defined in `.data-grid th > .header-cell-content`.
+
+ (.data-grid.timeline th > .header-cell-content.timeline-ruler > .markers):
+ (.data-grid.timeline th:matches(.sort-ascending, .sort-descending) > .header-cell-content.timeline-ruler:first-child::after):
+ `.header-cell-content.timeline-ruler` is different from `.header-cell-content` in the sense that the former takes the entire
+ height of DataGrid and has no padding. Place the chevron in the middle of `--data-grid-header-height`.
+
2020-08-05 Tim Horton <timothy_hor...@apple.com>
Remove all references to non-existent 10.16
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css (265355 => 265356)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css 2020-08-07 00:00:54 UTC (rev 265355)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css 2020-08-07 00:19:15 UTC (rev 265356)
@@ -28,6 +28,8 @@
outline: none;
--data-grid-header-horizontal-padding: 6px;
+ --data-grid-header-height: 22px;
+ --data-grid-sorting-indicator-height: 8px;
}
.data-grid .highlight {
@@ -77,7 +79,7 @@
}
.data-grid th {
- height: 22px;
+ height: var(--data-grid-header-height);
padding: 0;
text-align: start;
vertical-align: middle;
@@ -227,7 +229,7 @@
top: 1px;
bottom: 0;
width: 9px;
- height: 8px;
+ height: var(--data-grid-sorting-indicator-height);
margin-bottom: auto;
margin-top: auto;
content: "";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.css (265355 => 265356)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.css 2020-08-07 00:00:54 UTC (rev 265355)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.css 2020-08-07 00:19:15 UTC (rev 265356)
@@ -46,8 +46,18 @@
top: 0;
bottom: 0;
margin: 0;
+ padding: 0;
}
+.data-grid.timeline th > .header-cell-content.timeline-ruler > .markers {
+ position: absolute;
+}
+
+.data-grid.timeline th:matches(.sort-ascending, .sort-descending) > .header-cell-content.timeline-ruler:first-child::after {
+ top: calc(var(--data-grid-header-height) / 2 - var(--data-grid-sorting-indicator-height) / 2);
+ bottom: unset;
+}
+
.data-grid.timeline td.graph-column {
padding: 2px 0;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
