Title: [265362] trunk/LayoutTests
Revision
265362
Author
ysuz...@apple.com
Date
2020-08-06 22:12:24 -0700 (Thu, 06 Aug 2020)

Log Message

Unreviewed, fix fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html test

It may not throw an exception, depending on GC.

* TestExpectations:
* fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt:
* fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (265361 => 265362)


--- trunk/LayoutTests/ChangeLog	2020-08-07 01:24:05 UTC (rev 265361)
+++ trunk/LayoutTests/ChangeLog	2020-08-07 05:12:24 UTC (rev 265362)
@@ -1,3 +1,13 @@
+2020-08-06  Yusuke Suzuki  <ysuz...@apple.com>
+
+        Unreviewed, fix fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html test
+
+        It may not throw an exception, depending on GC.
+
+        * TestExpectations:
+        * fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt:
+        * fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js:
+
 2020-08-06  Kenneth Russell  <k...@chromium.org>
 
         Implement createImageBitmap(ImageData)

Modified: trunk/LayoutTests/TestExpectations (265361 => 265362)


--- trunk/LayoutTests/TestExpectations	2020-08-07 01:24:05 UTC (rev 265361)
+++ trunk/LayoutTests/TestExpectations	2020-08-07 05:12:24 UTC (rev 265362)
@@ -1133,6 +1133,9 @@
 webkit.org/b/136078 fast/borders/border-painting-dotted.html [ ImageOnlyFailure ]
 webkit.org/b/136078 fast/borders/border-painting-double.html [ ImageOnlyFailure ]
 
+# Console log may not appear, which depends on GC behavior. So we silence them.
+[ Release ] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html [ DumpJSConsoleLogInStdErr ]
+
 # Skip this because it is too slow on debug builds.
 [ Debug ] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html [ Skip ]
 

Modified: trunk/LayoutTests/fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt (265361 => 265362)


--- trunk/LayoutTests/fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt	2020-08-07 01:24:05 UTC (rev 265361)
+++ trunk/LayoutTests/fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt	2020-08-07 05:12:24 UTC (rev 265362)
@@ -1,2 +1 @@
-CONSOLE MESSAGE: RangeError: Out of memory
 

Modified: trunk/LayoutTests/fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js (265361 => 265362)


--- trunk/LayoutTests/fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js	2020-08-07 01:24:05 UTC (rev 265361)
+++ trunk/LayoutTests/fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js	2020-08-07 05:12:24 UTC (rev 265362)
@@ -14,7 +14,7 @@
     } catch { }
 }
 
-var exception;
+var exception = null;
 useAllMemory();
 try {
     for (let i = 0; i < 1000; i++) {
@@ -24,5 +24,8 @@
     exception = e;
 }
 
-if (exception != "RangeError: Out of memory")
-    throw "FAIL: expect: 'RangeError: Out of memory', actual: '" + exception + "'";
+// Exception may not be thrown, depends on GC timing.
+if (exception !== null) {
+    if (exception != "RangeError: Out of memory")
+        throw "FAIL: expect: 'RangeError: Out of memory', actual: '" + exception + "'";
+}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to