Title: [265370] trunk/Tools
- Revision
- 265370
- Author
- aakash_j...@apple.com
- Date
- 2020-08-07 07:05:04 -0700 (Fri, 07 Aug 2020)
Log Message
EWS emails about build failure should include last few relevant error logs
https://bugs.webkit.org/show_bug.cgi?id=215264
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.filter_logs_containing_error):
* BuildSlaveSupport/ews-build/steps_unittest.py:
(TestAnalyzeCompileWebKitResults.test_filter_logs_containing_error_with_too_many_errors):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (265369 => 265370)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-08-07 11:32:56 UTC (rev 265369)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-08-07 14:05:04 UTC (rev 265370)
@@ -1441,7 +1441,7 @@
for line in logs.splitlines():
if 'rror:' in line:
filtered_logs.append(line)
- return '\n'.join(filtered_logs[:max_num_lines])
+ return '\n'.join(filtered_logs[-max_num_lines:])
def send_email_for_new_build_failure(self):
try:
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (265369 => 265370)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2020-08-07 11:32:56 UTC (rev 265369)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2020-08-07 14:05:04 UTC (rev 265370)
@@ -1116,7 +1116,7 @@
def test_filter_logs_containing_error_with_too_many_errors(self):
logs = 'Error:1\nError:2\nerror:3\nerror:4\nerror:5\nrandom-string\nerror:6\nerror:7\nerror8\nerror:9\nerror:10\nerror:11\nerror:12\nerror:13'
- expected_output = 'Error:1\nError:2\nerror:3\nerror:4\nerror:5\nerror:6\nerror:7\nerror:9\nerror:10\nerror:11'
+ expected_output = 'error:3\nerror:4\nerror:5\nerror:6\nerror:7\nerror:9\nerror:10\nerror:11\nerror:12\nerror:13'
output = AnalyzeCompileWebKitResults().filter_logs_containing_error(logs)
self.assertEqual(expected_output, output)
Modified: trunk/Tools/ChangeLog (265369 => 265370)
--- trunk/Tools/ChangeLog 2020-08-07 11:32:56 UTC (rev 265369)
+++ trunk/Tools/ChangeLog 2020-08-07 14:05:04 UTC (rev 265370)
@@ -1,3 +1,15 @@
+2020-08-07 Aakash Jain <aakash_j...@apple.com>
+
+ EWS emails about build failure should include last few relevant error logs
+ https://bugs.webkit.org/show_bug.cgi?id=215264
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (AnalyzeCompileWebKitResults.filter_logs_containing_error):
+ * BuildSlaveSupport/ews-build/steps_unittest.py:
+ (TestAnalyzeCompileWebKitResults.test_filter_logs_containing_error_with_too_many_errors):
+
2020-08-07 Youenn Fablet <you...@apple.com>
Introduce a Vector::isolatedCopy() &&
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
