Title: [265496] trunk/Tools
Revision
265496
Author
commit-qu...@webkit.org
Date
2020-08-11 06:27:23 -0700 (Tue, 11 Aug 2020)

Log Message

[GTK][WPE] Add MiniBrowser wrapper env vars and white-list MESA env vars in flatpak
https://bugs.webkit.org/show_bug.cgi?id=215361

Patch by Philippe Normand <pnorm...@igalia.com> on 2020-08-11
Reviewed by Žan Doberšek.

* Scripts/webkitpy/port/gtk.py:
(GtkPort.run_minibrowser): Add support for the $WEBKIT_MINI_BROWSER_PREFIX env var which can
be useful when debugging MiniBrowser with gdb or rr.
* Scripts/webkitpy/port/wpe.py:
(WPEPort.run_minibrowser): Ditto.
* flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox): White-list MESA environment variables in the sandbox.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (265495 => 265496)


--- trunk/Tools/ChangeLog	2020-08-11 12:11:24 UTC (rev 265495)
+++ trunk/Tools/ChangeLog	2020-08-11 13:27:23 UTC (rev 265496)
@@ -1,5 +1,20 @@
 2020-08-11  Philippe Normand  <pnorm...@igalia.com>
 
+        [GTK][WPE] Add MiniBrowser wrapper env vars and white-list MESA env vars in flatpak
+        https://bugs.webkit.org/show_bug.cgi?id=215361
+
+        Reviewed by Žan Doberšek.
+
+        * Scripts/webkitpy/port/gtk.py:
+        (GtkPort.run_minibrowser): Add support for the $WEBKIT_MINI_BROWSER_PREFIX env var which can
+        be useful when debugging MiniBrowser with gdb or rr.
+        * Scripts/webkitpy/port/wpe.py:
+        (WPEPort.run_minibrowser): Ditto.
+        * flatpak/flatpakutils.py:
+        (WebkitFlatpak.run_in_sandbox): White-list MESA environment variables in the sandbox.
+
+2020-08-11  Philippe Normand  <pnorm...@igalia.com>
+
         [GStreamer] gst-full standalone library support
         https://bugs.webkit.org/show_bug.cgi?id=215262
 

Modified: trunk/Tools/Scripts/webkitpy/port/gtk.py (265495 => 265496)


--- trunk/Tools/Scripts/webkitpy/port/gtk.py	2020-08-11 12:11:24 UTC (rev 265495)
+++ trunk/Tools/Scripts/webkitpy/port/gtk.py	2020-08-11 13:27:23 UTC (rev 265496)
@@ -267,6 +267,8 @@
             print("%s not found... Did you run build-webkit?" % miniBrowser)
             return 1
         command = [miniBrowser]
+        if os.environ.get("WEBKIT_MINI_BROWSER_PREFIX"):
+            command.insert(0, os.environ["WEBKIT_MINI_BROWSER_PREFIX"])
         if self._should_use_jhbuild():
             command = self._jhbuild_wrapper + command
         return self._executive.run_command(command + args, cwd=self.webkit_base(), stdout=None, return_stderr=False, decode_output=False)

Modified: trunk/Tools/Scripts/webkitpy/port/wpe.py (265495 => 265496)


--- trunk/Tools/Scripts/webkitpy/port/wpe.py	2020-08-11 12:11:24 UTC (rev 265495)
+++ trunk/Tools/Scripts/webkitpy/port/wpe.py	2020-08-11 13:27:23 UTC (rev 265496)
@@ -32,8 +32,8 @@
 from webkitpy.port.base import Port
 from webkitpy.port.headlessdriver import HeadlessDriver
 from webkitpy.port.linux_get_crash_log import GDBCrashLogGenerator
+import os
 
-
 class WPEPort(Port):
     port_name = "wpe"
 
@@ -140,6 +140,8 @@
             print("%s not found... Did you run build-webkit?" % miniBrowser)
             return 1
         command = [miniBrowser]
+        if os.environ.get("WEBKIT_MINI_BROWSER_PREFIX"):
+            command.insert(0, os.environ["WEBKIT_MINI_BROWSER_PREFIX"])
         if self._should_use_jhbuild():
             command = self._jhbuild_wrapper + command
         return self._executive.run_command(command + args, cwd=self.webkit_base(), stdout=None, return_stderr=False, decode_output=False)

Modified: trunk/Tools/flatpak/flatpakutils.py (265495 => 265496)


--- trunk/Tools/flatpak/flatpakutils.py	2020-08-11 12:11:24 UTC (rev 265495)
+++ trunk/Tools/flatpak/flatpakutils.py	2020-08-11 13:27:23 UTC (rev 265496)
@@ -728,6 +728,7 @@
             "GTK",
             "ICECC",
             "JSC",
+            "MESA",
             "RUST",
             "SCCACHE",
             "WAYLAND",
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to