Title: [265501] trunk
- Revision
- 265501
- Author
- you...@apple.com
- Date
- 2020-08-11 10:07:29 -0700 (Tue, 11 Aug 2020)
Log Message
Add JS console log message in case of capture failure
https://bugs.webkit.org/show_bug.cgi?id=215370
Reviewed by Eric Carlson.
Source/WebCore:
Covered by rebased test.
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::trackEnded):
LayoutTests:
* fast/mediastream/media-stream-track-source-failure-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (265500 => 265501)
--- trunk/LayoutTests/ChangeLog 2020-08-11 17:06:31 UTC (rev 265500)
+++ trunk/LayoutTests/ChangeLog 2020-08-11 17:07:29 UTC (rev 265501)
@@ -1,3 +1,12 @@
+2020-08-11 Youenn Fablet <you...@apple.com>
+
+ Add JS console log message in case of capture failure
+ https://bugs.webkit.org/show_bug.cgi?id=215370
+
+ Reviewed by Eric Carlson.
+
+ * fast/mediastream/media-stream-track-source-failure-expected.txt:
+
2020-08-11 Zalan Bujtas <za...@apple.com>
[AutoTableLayout] REGRESSION(r263855) Paypal email is rendered right aligned on Safari
Modified: trunk/LayoutTests/fast/mediastream/media-stream-track-source-failure-expected.txt (265500 => 265501)
--- trunk/LayoutTests/fast/mediastream/media-stream-track-source-failure-expected.txt 2020-08-11 17:06:31 UTC (rev 265500)
+++ trunk/LayoutTests/fast/mediastream/media-stream-track-source-failure-expected.txt 2020-08-11 17:07:29 UTC (rev 265501)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: A MediaStreamTrack ended due to a capture failure
+CONSOLE MESSAGE: A MediaStreamTrack ended due to a capture failure
PASS Create stream
Modified: trunk/Source/WebCore/ChangeLog (265500 => 265501)
--- trunk/Source/WebCore/ChangeLog 2020-08-11 17:06:31 UTC (rev 265500)
+++ trunk/Source/WebCore/ChangeLog 2020-08-11 17:07:29 UTC (rev 265501)
@@ -1,3 +1,15 @@
+2020-08-11 Youenn Fablet <you...@apple.com>
+
+ Add JS console log message in case of capture failure
+ https://bugs.webkit.org/show_bug.cgi?id=215370
+
+ Reviewed by Eric Carlson.
+
+ Covered by rebased test.
+
+ * Modules/mediastream/MediaStreamTrack.cpp:
+ (WebCore::MediaStreamTrack::trackEnded):
+
2020-08-11 Zalan Bujtas <za...@apple.com>
[AutoTableLayout] REGRESSION(r263855) Paypal email is rendered right aligned on Safari
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp (265500 => 265501)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2020-08-11 17:06:31 UTC (rev 265500)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2020-08-11 17:07:29 UTC (rev 265501)
@@ -535,6 +535,9 @@
if (m_ended)
return;
+ if (m_isCaptureTrack && m_private->source().captureDidFail())
+ scriptExecutionContext()->addConsoleMessage(MessageSource::JS, MessageLevel::Error, "A MediaStreamTrack ended due to a capture failure"_s);
+
// 2. Set track's readyState attribute to ended.
m_ended = true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
