[webkit-changes] [265565] trunk/Tools

Wed, 12 Aug 2020 16:07:16 -0700

Title: [265565] trunk/Tools
Revision
265565
Author
aakash_j...@apple.com
Date
2020-08-12 14:40:17 -0700 (Wed, 12 Aug 2020)

Log Message

[ews] email notifications should include link to corresponding bug
https://bugs.webkit.org/show_bug.cgi?id=215425

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure):
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures):

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (265564 => 265565)


--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2020-08-12 21:31:45 UTC (rev 265564)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2020-08-12 21:40:17 UTC (rev 265565)
@@ -366,6 +366,15 @@
             return {u'step': u'Patch doesn\'t have relevant changes'}
         return super(CheckPatchRelevance, self).getResultSummary()
 
+
+class Bugzilla(object):
+    @classmethod
+    def bug_url(cls, bug_id):
+        if not bug_id:
+            return ''
+        return '{}show_bug.cgi?id={}'.format(BUG_SERVER_URL, bug_id)
+
+
 class BugzillaMixin(object):
     addURLs = False
     bug_open_statuses = ['UNCONFIRMED', 'NEW', 'ASSIGNED', 'REOPENED']
@@ -514,7 +523,7 @@
             self.setProperty('sensitive', True)
             bug_title = ''
         if self.addURLs:
-            self.addURL(u'Bug {} {}'.format(bug_id, bug_title), '{}show_bug.cgi?id={}'.format(BUG_SERVER_URL, bug_id))
+            self.addURL(u'Bug {} {}'.format(bug_id, bug_title), Bugzilla.bug_url(bug_id))
         if bug_json.get('status') in self.bug_closed_statuses:
             return 1
         return 0
@@ -1458,6 +1467,7 @@
     def send_email_for_new_build_failure(self):
         try:
             builder_name = self.getProperty('buildername', '')
+            bug_id = self.getProperty('bug_id', '')
             bug_title = self.getProperty('bug_title', '')
             worker_name = self.getProperty('workername', '')
             patch_id = self.getProperty('patch_id', '')
@@ -1471,7 +1481,8 @@
                 logs = self.filter_logs_containing_error(logs)
 
             email_subject = 'Build failure for Patch {}: {}'.format(patch_id, bug_title)
-            email_text = 'EWS has detected build failure on {} while testing Patch {}.'.format(builder_name, patch_id)
+            email_text = 'EWS has detected build failure on {} while testing Patch {}'.format(builder_name, patch_id)
+            email_text += ' for <a href="" {}</a>.'.format(Bugzilla.bug_url(bug_id), bug_id)
             email_text += '\n\nFull details are available at: {}\n\nPatch author: {}'.format(build_url, patch_author)
             if logs:
                 logs = logs.replace('&', '&amp;').replace('<', '&lt;').replace('>', '&gt;')
@@ -2132,6 +2143,7 @@
     def send_email_for_new_test_failures(self, test_names):
         try:
             builder_name = self.getProperty('buildername', '')
+            bug_id = self.getProperty('bug_id', '')
             bug_title = self.getProperty('bug_title', '')
             worker_name = self.getProperty('workername', '')
             patch_id = self.getProperty('patch_id', '')
@@ -2143,7 +2155,8 @@
                 test_names_string += '\n- {} (<a href="" history</a>)'.format(test_name, history_url)
 
             email_subject = 'Layout test failure for Patch {}: {} '.format(patch_id, bug_title)
-            email_text = 'EWS has detected test failure on {} while testing Patch {}.'.format(builder_name, patch_id)
+            email_text = 'EWS has detected test failure on {} while testing Patch {}'.format(builder_name, patch_id)
+            email_text += ' for <a href="" {}</a>.'.format(Bugzilla.bug_url(bug_id), bug_id)
             email_text += '\n\nFull details are available at: {}\n\nPatch author: {}'.format(build_url, patch_author)
             email_text += '\n\nLayout test failure:\n{}'.format(test_names_string)
             email_text += '\n\nTo unsubscrible from these notifications or to provide any feedback please email aakash_j...@apple.com'

Modified: trunk/Tools/ChangeLog (265564 => 265565)


--- trunk/Tools/ChangeLog	2020-08-12 21:31:45 UTC (rev 265564)
+++ trunk/Tools/ChangeLog	2020-08-12 21:40:17 UTC (rev 265565)
@@ -1,3 +1,14 @@
+2020-08-12  Aakash Jain  <aakash_j...@apple.com>
+
+        [ews] email notifications should include link to corresponding bug
+        https://bugs.webkit.org/show_bug.cgi?id=215425
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (AnalyzeCompileWebKitResults.send_email_for_new_build_failure):
+        (AnalyzeLayoutTestsResults.send_email_for_new_test_failures):
+
 2020-08-12  Wenson Hsieh  <wenson_hs...@apple.com>
 
         Broken formatting in price table on yandex.ru after translating to English

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to