Title: [266053] trunk/JSTests
Revision
266053
Author
ysuz...@apple.com
Date
2020-08-24 02:55:13 -0700 (Mon, 24 Aug 2020)

Log Message

Unreviewed, ignore RangeErrors when ICU is too old

Since ICU version is different (very sad), some of tests can throw an error.

* stress/intl-language-tag.js:
(let.shouldThrow):
(let.shouldNotThrow):
(suppressErrors):
(vm.icuVersion):
(shouldThrow): Deleted.
(shouldNotThrow): Deleted.

Modified Paths

Diff

Modified: trunk/JSTests/ChangeLog (266052 => 266053)


--- trunk/JSTests/ChangeLog	2020-08-24 09:26:58 UTC (rev 266052)
+++ trunk/JSTests/ChangeLog	2020-08-24 09:55:13 UTC (rev 266053)
@@ -1,3 +1,17 @@
+2020-08-24  Yusuke Suzuki  <ysuz...@apple.com>
+
+        Unreviewed, ignore RangeErrors when ICU is too old
+
+        Since ICU version is different (very sad), some of tests can throw an error.
+
+        * stress/intl-language-tag.js:
+        (let.shouldThrow):
+        (let.shouldNotThrow):
+        (suppressErrors):
+        (vm.icuVersion):
+        (shouldThrow): Deleted.
+        (shouldNotThrow): Deleted.
+
 2020-08-22  Yusuke Suzuki  <ysuz...@apple.com>
 
         [JSC] Implement Intl Language Tag Parser

Modified: trunk/JSTests/stress/intl-language-tag.js (266052 => 266053)


--- trunk/JSTests/stress/intl-language-tag.js	2020-08-24 09:26:58 UTC (rev 266052)
+++ trunk/JSTests/stress/intl-language-tag.js	2020-08-24 09:55:13 UTC (rev 266053)
@@ -31,11 +31,17 @@
 shouldThrow(() => Intl.getCanonicalLocales("en-US-a-xxxxxxxxxxxxxxxxxxx"), RangeError);
 shouldThrow(() => Intl.getCanonicalLocales("en-US-a-ok-ok-$"), RangeError);
 shouldNotThrow(() => Intl.getCanonicalLocales("en-US-a-ok-ok"));
-shouldNotThrow(() => Intl.getCanonicalLocales("en-US-0-ok1"));
+if ($vm.icuVersion() < 64)
+    shouldThrow(() => Intl.getCanonicalLocales("en-US-0-ok1"), RangeError);
+else
+    shouldNotThrow(() => Intl.getCanonicalLocales("en-US-0-ok1"));
 shouldThrow(() => Intl.getCanonicalLocales("en-US-0"), RangeError);
 shouldThrow(() => Intl.getCanonicalLocales("en-US-0-xxxxxxxxxxxxxxxxxxx"), RangeError);
 shouldThrow(() => Intl.getCanonicalLocales("en-US-0-ok-ok-$"), RangeError);
-shouldNotThrow(() => Intl.getCanonicalLocales("en-US-0-ok-ok"));
+if ($vm.icuVersion() < 64)
+    shouldThrow(() => Intl.getCanonicalLocales("en-US-0-ok-ok"), RangeError);
+else
+    shouldNotThrow(() => Intl.getCanonicalLocales("en-US-0-ok-ok"));
 shouldNotThrow(() => Intl.getCanonicalLocales("de"));
 shouldNotThrow(() => Intl.getCanonicalLocales("fr"));
 shouldNotThrow(() => Intl.getCanonicalLocales("ja"));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to