Title: [266463] trunk/Source/WebInspectorUI
Revision
266463
Author
drou...@apple.com
Date
2020-09-02 08:48:26 -0700 (Wed, 02 Sep 2020)

Log Message

Web Inspector: Timelines: re-enabling the _javascript_ Allocations timeline doesn't show previously captured heap snapshots in the table
https://bugs.webkit.org/show_bug.cgi?id=216057
<rdar://problem/68172848>

Reviewed by Brian Burg.

* UserInterface/Views/HeapAllocationsTimelineView.js:
(WI.HeapAllocationsTimelineView):
Add a `WI.HeapAllocationsTimelineDataGridNode` for each `WI.HeapAllocationsTimelineRecord`
that already exists when the `WI.HeapAllocationsTimelineView` is created.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (266462 => 266463)


--- trunk/Source/WebInspectorUI/ChangeLog	2020-09-02 15:37:21 UTC (rev 266462)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-09-02 15:48:26 UTC (rev 266463)
@@ -1,3 +1,16 @@
+2020-09-02  Devin Rousso  <drou...@apple.com>
+
+        Web Inspector: Timelines: re-enabling the _javascript_ Allocations timeline doesn't show previously captured heap snapshots in the table
+        https://bugs.webkit.org/show_bug.cgi?id=216057
+        <rdar://problem/68172848>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/HeapAllocationsTimelineView.js:
+        (WI.HeapAllocationsTimelineView):
+        Add a `WI.HeapAllocationsTimelineDataGridNode` for each `WI.HeapAllocationsTimelineRecord`
+        that already exists when the `WI.HeapAllocationsTimelineView` is created.
+
 2020-09-01  Nikita Vasilyev  <nvasil...@apple.com>
 
         REGRESSION(r243264): Web Inspector: Style pane doesn't update after toggling CSS class

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js (266462 => 266463)


--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js	2020-09-02 15:37:21 UTC (rev 266462)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js	2020-09-02 15:48:26 UTC (rev 266463)
@@ -100,7 +100,7 @@
         this._contentViewContainer.addEventListener(WI.ContentViewContainer.Event.CurrentContentViewDidChange, this._currentContentViewDidChange, this);
         WI.ContentView.addEventListener(WI.ContentView.Event.SelectionPathComponentsDidChange, this._contentViewSelectionPathComponentDidChange, this);
 
-        this._pendingRecords = [];
+        this._pendingRecords = Array.from(timeline.records);
 
         timeline.addEventListener(WI.Timeline.Event.RecordAdded, this._heapAllocationsTimelineRecordAdded, this);
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to