Title: [266477] trunk/Source/WebInspectorUI
- Revision
- 266477
- Author
- drou...@apple.com
- Date
- 2020-09-02 11:44:31 -0700 (Wed, 02 Sep 2020)
Log Message
Web Inspector: Timelines: duplicate "Timeline Recording 1" on open
https://bugs.webkit.org/show_bug.cgi?id=216060
Reviewed by Brian Burg.
* UserInterface/Controllers/TimelineManager.js:
(WI.TimelineManager):
(WI.TimelineManager.prototype.get recordings): Deleted.
Don't `reset` in the `constructor` as this is already done in `enable` and `disable`, which
is called whenever the Timeline Tab is added/removed.
* UserInterface/Views/TimelineTabContentView.js:
(WI.TimelineTabContentView):
There should never be any existing recordings when adding the Timelines Tab, as they should
have been removed when the tab was last removed (via `WI.TimelineManager.prototype.disable`).
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (266476 => 266477)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-09-02 18:32:03 UTC (rev 266476)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-09-02 18:44:31 UTC (rev 266477)
@@ -1,5 +1,23 @@
2020-09-02 Devin Rousso <drou...@apple.com>
+ Web Inspector: Timelines: duplicate "Timeline Recording 1" on open
+ https://bugs.webkit.org/show_bug.cgi?id=216060
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Controllers/TimelineManager.js:
+ (WI.TimelineManager):
+ (WI.TimelineManager.prototype.get recordings): Deleted.
+ Don't `reset` in the `constructor` as this is already done in `enable` and `disable`, which
+ is called whenever the Timeline Tab is added/removed.
+
+ * UserInterface/Views/TimelineTabContentView.js:
+ (WI.TimelineTabContentView):
+ There should never be any existing recordings when adding the Timelines Tab, as they should
+ have been removed when the tab was last removed (via `WI.TimelineManager.prototype.disable`).
+
+2020-09-02 Devin Rousso <drou...@apple.com>
+
Web Inspector: REGRESSION(?): Timelines: Frames: clicking a record bar to select it when another record bar is already selected instead removes all selections
https://bugs.webkit.org/show_bug.cgi?id=216045
<rdar://problem/68156740>
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js (266476 => 266477)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2020-09-02 18:32:03 UTC (rev 266476)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2020-09-02 18:44:31 UTC (rev 266477)
@@ -59,8 +59,6 @@
this._stopCapturingTimeout = undefined;
this._deadTimeTimeout = undefined;
this._lastDeadTimeTickle = 0;
-
- this.reset();
}
// Agent
@@ -187,11 +185,6 @@
return this._activeRecording;
}
- get recordings()
- {
- return this._recordings.slice();
- }
-
get autoCaptureOnPageLoad()
{
return this._autoCaptureOnPageLoad;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js (266476 => 266477)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js 2020-09-02 18:32:03 UTC (rev 266476)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js 2020-09-02 18:44:31 UTC (rev 266477)
@@ -83,14 +83,6 @@
const selectedByUser = false;
this._changeViewMode(WI.TimelineOverview.ViewMode.Timelines, selectedByUser);
- for (let recording of WI.timelineManager.recordings)
- this._addRecording(recording);
-
- this._recordingCountChanged();
-
- // Explicitly update the path for the navigation bar to prevent it from showing up as blank.
- this.contentBrowser.updateHierarchicalPathForCurrentContentView();
-
WI.heapManager.enable();
WI.memoryManager.enable();
WI.timelineManager.enable();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
