Diff
Modified: trunk/Tools/ChangeLog (266729 => 266730)
--- trunk/Tools/ChangeLog 2020-09-08 17:51:04 UTC (rev 266729)
+++ trunk/Tools/ChangeLog 2020-09-08 17:56:28 UTC (rev 266730)
@@ -1,3 +1,16 @@
+2020-09-08 Aakash Jain <aakash_j...@apple.com>
+
+ Use https urls instead of http in webkitpy
+ https://bugs.webkit.org/show_bug.cgi?id=216276
+
+ Reviewed by Jonathan Bedard.
+
+ * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
+ * Scripts/webkitpy/common/config/urls.py:
+ * Scripts/webkitpy/common/config/urls_unittest.py: Changed few http urls to https, leaving a mix of http and https for testing.
+ * Scripts/webkitpy/common/config/watchlist:
+ * Scripts/webkitpy/style/checkers/cpp.py:
+
2020-09-08 Philippe Normand <pnorm...@igalia.com>
[Flatpak SDK] Follow-up fixes for 0.3 branch
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm_mock.py (266729 => 266730)
--- trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm_mock.py 2020-09-08 17:51:04 UTC (rev 266729)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm_mock.py 2020-09-08 17:56:28 UTC (rev 266730)
@@ -127,7 +127,7 @@
return path + '-diff'
def diff_for_revision(self, revision):
- return "DiffForRevision%s\nhttp://bugs.webkit.org/show_bug.cgi?id=12345" % revision
+ return "DiffForRevision%s\nhttps://bugs.webkit.org/show_bug.cgi?id=12345" % revision
def show_head(self, path):
return path
Modified: trunk/Tools/Scripts/webkitpy/common/config/urls.py (266729 => 266730)
--- trunk/Tools/Scripts/webkitpy/common/config/urls.py 2020-09-08 17:51:04 UTC (rev 266729)
+++ trunk/Tools/Scripts/webkitpy/common/config/urls.py 2020-09-08 17:56:28 UTC (rev 266730)
@@ -38,7 +38,7 @@
return "https://trac.webkit.org/changeset/%s" % revision_number
-contribution_guidelines = "http://webkit.org/coding/contributing.html"
+contribution_guidelines = "https://webkit.org/coding/contributing.html"
bug_server_domain = "webkit.org"
bug_server_host = "bugs." + bug_server_domain
Modified: trunk/Tools/Scripts/webkitpy/common/config/urls_unittest.py (266729 => 266730)
--- trunk/Tools/Scripts/webkitpy/common/config/urls_unittest.py 2020-09-08 17:51:04 UTC (rev 266729)
+++ trunk/Tools/Scripts/webkitpy/common/config/urls_unittest.py 2020-09-08 17:56:28 UTC (rev 266730)
@@ -35,19 +35,19 @@
def test_parse_bug_id(self):
# FIXME: These would be all better as doctests
self.assertEqual(12345, parse_bug_id("http://webkit.org/b/12345"))
- self.assertEqual(12345, parse_bug_id("foo\n\nhttp://webkit.org/b/12345\nbar\n\n"))
- self.assertEqual(12345, parse_bug_id("http://bugs.webkit.org/show_bug.cgi?id=12345"))
- self.assertEqual(12345, parse_bug_id("http://bugs.webkit.org/show_bug.cgi?id=12345&ctype=xml"))
- self.assertEqual(12345, parse_bug_id("http://bugs.webkit.org/show_bug.cgi?id=12345&ctype=xml&excludefield=attachmentdata"))
- self.assertEqual(12345, parse_bug_id("http://bugs.webkit.org/show_bug.cgi?id=12345excludefield=attachmentdata&ctype=xml"))
+ self.assertEqual(12345, parse_bug_id("foo\n\nhttps://webkit.org/b/12345\nbar\n\n"))
+ self.assertEqual(12345, parse_bug_id("https://bugs.webkit.org/show_bug.cgi?id=12345"))
+ self.assertEqual(12345, parse_bug_id("https://bugs.webkit.org/show_bug.cgi?id=12345&ctype=xml"))
+ self.assertEqual(12345, parse_bug_id("https://bugs.webkit.org/show_bug.cgi?id=12345&ctype=xml&excludefield=attachmentdata"))
+ self.assertEqual(12345, parse_bug_id("https://bugs.webkit.org/show_bug.cgi?id=12345excludefield=attachmentdata&ctype=xml"))
# Our url parser is super-fragile, but at least we're testing it.
self.assertIsNone(parse_bug_id("http://www.webkit.org/b/12345"))
- self.assertIsNone(parse_bug_id("http://bugs.webkit.org/show_bug.cgi?ctype=xml&id=12345"))
- self.assertIsNone(parse_bug_id("http://bugs.webkit.org/show_bug.cgi?ctype=xml&id=12345&excludefield=attachmentdata"))
- self.assertIsNone(parse_bug_id("http://bugs.webkit.org/show_bug.cgi?ctype=xml&excludefield=attachmentdata&id=12345"))
- self.assertIsNone(parse_bug_id("http://bugs.webkit.org/show_bug.cgi?excludefield=attachmentdata&ctype=xml&id=12345"))
- self.assertIsNone(parse_bug_id("http://bugs.webkit.org/show_bug.cgi?excludefield=attachmentdata&id=12345&ctype=xml"))
+ self.assertIsNone(parse_bug_id("https://bugs.webkit.org/show_bug.cgi?ctype=xml&id=12345"))
+ self.assertIsNone(parse_bug_id("https://bugs.webkit.org/show_bug.cgi?ctype=xml&id=12345&excludefield=attachmentdata"))
+ self.assertIsNone(parse_bug_id("https://bugs.webkit.org/show_bug.cgi?ctype=xml&excludefield=attachmentdata&id=12345"))
+ self.assertIsNone(parse_bug_id("https://bugs.webkit.org/show_bug.cgi?excludefield=attachmentdata&ctype=xml&id=12345"))
+ self.assertIsNone(parse_bug_id("https://bugs.webkit.org/show_bug.cgi?excludefield=attachmentdata&id=12345&ctype=xml"))
def test_parse_attachment_id(self):
self.assertEqual(12345, parse_attachment_id("https://bugs.webkit.org/attachment.cgi?id=12345&action=""
Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (266729 => 266730)
--- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2020-09-08 17:51:04 UTC (rev 266729)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2020-09-08 17:56:28 UTC (rev 266730)
@@ -485,9 +485,9 @@
"MESSAGE_RULES": {
"GtkWebKit2PublicAPI": [ "Thanks for the patch. If this patch contains new public API "
"please make sure it follows the guidelines for new WebKit2 GTK+ API. "
- "See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API", ],
+ "See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API", ],
"ANGLE": [ "Note that there are important steps to take when updating ANGLE. "
- "See http://trac.webkit.org/wiki/UpdatingANGLE", ],
+ "See https://trac.webkit.org/wiki/UpdatingANGLE", ],
"WebInspectorProtocol": [ "This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features." ],
"WebInspectorGenerator": [ "This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)" ],
"WebPlatformTests&!WebPlatformTestsImport": [ "This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess" ],
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (266729 => 266730)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2020-09-08 17:51:04 UTC (rev 266729)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2020-09-08 17:56:28 UTC (rev 266730)
@@ -3174,7 +3174,7 @@
if search(r'\bNULL\b', line):
# FIXME: We should recommend using nullptr instead of NULL in C++ code per
- # <http://www.webkit.org/coding/coding-style.html#zero-null>.
+ # <https://www.webkit.org/coding/coding-style.html#zero-null>.
error(line_number, 'readability/null', 5, 'Use nullptr instead of NULL.')
return
