Diff
Modified: trunk/Source/WebCore/CMakeLists.txt (267145 => 267146)
--- trunk/Source/WebCore/CMakeLists.txt 2020-09-16 15:51:12 UTC (rev 267145)
+++ trunk/Source/WebCore/CMakeLists.txt 2020-09-16 15:55:47 UTC (rev 267146)
@@ -1043,6 +1043,7 @@
page/IntersectionObserverEntry.idl
page/Location.idl
page/Navigator.idl
+ page/NavigatorCookies.idl
page/NavigatorID.idl
page/NavigatorLanguage.idl
page/NavigatorOnLine.idl
Modified: trunk/Source/WebCore/ChangeLog (267145 => 267146)
--- trunk/Source/WebCore/ChangeLog 2020-09-16 15:51:12 UTC (rev 267145)
+++ trunk/Source/WebCore/ChangeLog 2020-09-16 15:55:47 UTC (rev 267146)
@@ -1,3 +1,20 @@
+2020-09-16 Sam Weinig <wei...@apple.com>
+
+ [WebIDL] Move navigator.cookieEnabled to its own interface mixin, matching the spec
+ https://bugs.webkit.org/show_bug.cgi?id=216590
+
+ Reviewed by Youenn Fablet.
+
+ Adds NavigatorCookies interface mixin and includes it in Navigator.
+
+ * CMakeLists.txt:
+ * DerivedSources-input.xcfilelist:
+ * DerivedSources-output.xcfilelist:
+ * DerivedSources.make:
+ * WebCore.xcodeproj/project.pbxproj:
+ * page/Navigator.idl:
+ * page/NavigatorCookies.idl: Added.
+
2020-09-16 Adrian Perez de Castro <ape...@igalia.com>
Non-unified build fixes, early September 2020 edition
Modified: trunk/Source/WebCore/DerivedSources-input.xcfilelist (267145 => 267146)
--- trunk/Source/WebCore/DerivedSources-input.xcfilelist 2020-09-16 15:51:12 UTC (rev 267145)
+++ trunk/Source/WebCore/DerivedSources-input.xcfilelist 2020-09-16 15:55:47 UTC (rev 267146)
@@ -1019,6 +1019,7 @@
$(PROJECT_DIR)/page/IntersectionObserverEntry.idl
$(PROJECT_DIR)/page/Location.idl
$(PROJECT_DIR)/page/Navigator.idl
+$(PROJECT_DIR)/page/NavigatorCookies.idl
$(PROJECT_DIR)/page/NavigatorID.idl
$(PROJECT_DIR)/page/NavigatorIsLoggedIn.idl
$(PROJECT_DIR)/page/NavigatorLanguage.idl
Modified: trunk/Source/WebCore/DerivedSources-output.xcfilelist (267145 => 267146)
--- trunk/Source/WebCore/DerivedSources-output.xcfilelist 2020-09-16 15:51:12 UTC (rev 267145)
+++ trunk/Source/WebCore/DerivedSources-output.xcfilelist 2020-09-16 15:55:47 UTC (rev 267146)
@@ -1230,6 +1230,8 @@
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorBeacon.h
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorClipboard.cpp
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorClipboard.h
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorCookies.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorCookies.h
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorCredentials.cpp
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorCredentials.h
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSNavigatorEME.cpp
Modified: trunk/Source/WebCore/DerivedSources.make (267145 => 267146)
--- trunk/Source/WebCore/DerivedSources.make 2020-09-16 15:51:12 UTC (rev 267145)
+++ trunk/Source/WebCore/DerivedSources.make 2020-09-16 15:55:47 UTC (rev 267146)
@@ -1030,6 +1030,7 @@
$(WebCore)/page/IntersectionObserverEntry.idl \
$(WebCore)/page/Location.idl \
$(WebCore)/page/Navigator.idl \
+ $(WebCore)/page/NavigatorCookies.idl \
$(WebCore)/page/NavigatorID.idl \
$(WebCore)/page/NavigatorIsLoggedIn.idl \
$(WebCore)/page/NavigatorLanguage.idl \
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (267145 => 267146)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-09-16 15:51:12 UTC (rev 267145)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-09-16 15:55:47 UTC (rev 267146)
@@ -10136,6 +10136,7 @@
7C2E0BCF25106AC4005F3C87 /* WindowOrWorkerGlobalScopeFetch.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WindowOrWorkerGlobalScopeFetch.h; sourceTree = "<group>"; };
7C2E0BD025106AC4005F3C87 /* WindowOrWorkerGlobalScopeFetch.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = WindowOrWorkerGlobalScopeFetch.cpp; sourceTree = "<group>"; };
7C2E0BD125106AC4005F3C87 /* WindowOrWorkerGlobalScopeFetch.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = WindowOrWorkerGlobalScopeFetch.idl; sourceTree = "<group>"; };
+ 7C2E0BD92511800E005F3C87 /* NavigatorCookies.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = NavigatorCookies.idl; sourceTree = "<group>"; };
7C2FA60F1EA95A3200A03108 /* ResourceCryptographicDigest.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ResourceCryptographicDigest.cpp; sourceTree = "<group>"; };
7C2FA6101EA95A3200A03108 /* ResourceCryptographicDigest.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ResourceCryptographicDigest.h; sourceTree = "<group>"; };
7C30D97E1F815AC000268356 /* JSAbortController.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSAbortController.cpp; sourceTree = "<group>"; };
@@ -21559,6 +21560,7 @@
A9C6E65D0D746694006442E9 /* Navigator.idl */,
E12719C90EEEC21300F61213 /* NavigatorBase.cpp */,
E12719C60EEEC16800F61213 /* NavigatorBase.h */,
+ 7C2E0BD92511800E005F3C87 /* NavigatorCookies.idl */,
7C5BEA3A1E9EE77100CC517B /* NavigatorID.idl */,
6B507A22234BF34100BE7C62 /* NavigatorIsLoggedIn.cpp */,
6B507A21234BF34100BE7C62 /* NavigatorIsLoggedIn.h */,
Modified: trunk/Source/WebCore/page/Navigator.idl (267145 => 267146)
--- trunk/Source/WebCore/page/Navigator.idl 2020-09-16 15:51:12 UTC (rev 267145)
+++ trunk/Source/WebCore/page/Navigator.idl 2020-09-16 15:55:47 UTC (rev 267146)
@@ -21,13 +21,12 @@
GenerateIsReachable=ReachableFromDOMWindow,
JSCustomMarkFunction,
] interface Navigator {
- // FIXME: This is specified to be in it's own mixin called NavigatorCookies.
- // https://html.spec.whatwg.org/multipage/system-state.html#navigatorcookies
- readonly attribute boolean cookieEnabled;
-
+ // Non-standard.
[Conditional=NAVIGATOR_STANDALONE] readonly attribute boolean standalone;
- undefined getStorageUpdates(); // FIXME: Remove this method or rename to yieldForStorageUpdates.
+ // Non-standard.
+ // FIXME: Remove this. WebKit is the only engine that still has this.
+ undefined getStorageUpdates();
};
Navigator includes NavigatorID;
@@ -34,6 +33,7 @@
Navigator includes NavigatorLanguage;
Navigator includes NavigatorMaxTouchPoints;
Navigator includes NavigatorOnLine;
+Navigator includes NavigatorCookies;
Navigator includes NavigatorPlugins;
Navigator includes NavigatorServiceWorker;
Navigator includes NavigatorShare;
Added: trunk/Source/WebCore/page/NavigatorCookies.idl (0 => 267146)
--- trunk/Source/WebCore/page/NavigatorCookies.idl (rev 0)
+++ trunk/Source/WebCore/page/NavigatorCookies.idl 2020-09-16 15:55:47 UTC (rev 267146)
@@ -0,0 +1,29 @@
+/*
+ * Copyright (C) 2020 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+// https://html.spec.whatwg.org/multipage/system-state.html#navigatorcookies
+interface mixin NavigatorCookies {
+ readonly attribute boolean cookieEnabled;
+};
