Modified: trunk/Source/WebInspectorUI/ChangeLog (267978 => 267979)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-10-05 17:37:20 UTC (rev 267978)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-10-05 17:37:51 UTC (rev 267979)
@@ -1,5 +1,17 @@
2020-10-05 Devin Rousso <drou...@apple.com>
+ Web Inspector: Sources: add a + to the Local Overrides section
+ https://bugs.webkit.org/show_bug.cgi?id=217235
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/SourcesNavigationSidebarPanel.js:
+ (WI.SourcesNavigationSidebarPanel):
+ (WI.SourcesNavigationSidebarPanel.prototype._populateCreateLocalOverrideContextMenu): Added.
+ (WI.SourcesNavigationSidebarPanel.prototype._populateCreateResourceContextMenu):
+
+2020-10-05 Devin Rousso <drou...@apple.com>
+
Web Inspector: unable to create local override for resource that failed to load
https://bugs.webkit.org/show_bug.cgi?id=217234
<rdar://problem/69888143>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js (267978 => 267979)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js 2020-10-05 17:37:20 UTC (rev 267978)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js 2020-10-05 17:37:51 UTC (rev 267979)
@@ -229,8 +229,17 @@
this._localOverridesRow = new WI.DetailsSectionRow(WI.UIString("No Overrides"));
+ let localOverrideNavigationBarWrapper = document.createElement("div");
+
+ let localOverrideNavigationBar = new WI.NavigationBar;
+ localOverrideNavigationBarWrapper.appendChild(localOverrideNavigationBar.element);
+
+ this._createLocalOverrideButton = new WI.ButtonNavigationItem("create-local-override", WI.UIString("Create Local Override"), "Images/Plus13.svg", 13, 13);
+ WI.addMouseDownContextMenuHandlers(this._createLocalOverrideButton.element, this._populateCreateLocalOverrideContextMenu.bind(this));
+ localOverrideNavigationBar.addNavigationItem(this._createLocalOverrideButton);
+
let localOverridesGroup = new WI.DetailsSectionGroup([this._localOverridesRow]);
- this._localOverridesSection = new WI.DetailsSection("local-overrides", WI.UIString("Local Overrides"), [localOverridesGroup]);
+ this._localOverridesSection = new WI.DetailsSection("local-overrides", WI.UIString("Local Overrides"), [localOverridesGroup], localOverrideNavigationBarWrapper);
this._localOverridesContainer = this.contentView.element.appendChild(document.createElement("div"));
this._localOverridesContainer.classList.add("local-overrides-container");
@@ -2031,6 +2040,24 @@
}
}
+ _populateCreateLocalOverrideContextMenu(contextMenu)
+ {
+ if (WI.NetworkManager.supportsOverridingResponses()) {
+ contextMenu.appendItem(WI.UIString("Local Override\u2026"), () => {
+ let popover = new WI.LocalResourceOverridePopover(this);
+ popover.show(null, this._createLocalOverrideButton.element, [WI.RectEdge.MAX_Y, WI.RectEdge.MIN_Y, WI.RectEdge.MAX_X]);
+ });
+ }
+
+ if (WI.NetworkManager.supportsBootstrapScript()) {
+ contextMenu.appendItem(WI.UIString("Inspector Bootstrap Script"), async () => {
+ await WI.networkManager.createBootstrapScript();
+ WI.networkManager.bootstrapScriptEnabled = true;
+ WI.showRepresentedObject(WI.networkManager.bootstrapScript);
+ });
+ }
+ }
+
_populateCreateResourceContextMenu(contextMenu)
{
if (WI.NetworkManager.supportsOverridingResponses()) {
@@ -2040,10 +2067,10 @@
this._localOverridesContainer.hidden = false;
- this._localOverridesSection.titleElement.scrollIntoViewIfNeeded(false);
+ this._createLocalOverrideButton.element.scrollIntoViewIfNeeded(false);
requestAnimationFrame(() => {
let popover = new WI.LocalResourceOverridePopover(this);
- popover.show(null, this._localOverridesSection.titleElement, [WI.RectEdge.MAX_Y, WI.RectEdge.MIN_Y, WI.RectEdge.MAX_X]);
+ popover.show(null, this._createLocalOverrideButton.element, [WI.RectEdge.MAX_Y, WI.RectEdge.MIN_Y, WI.RectEdge.MAX_X]);
});
});
}
