Title: [268016] trunk/Source/WebInspectorUI
- Revision
- 268016
- Author
- commit-qu...@webkit.org
- Date
- 2020-10-05 16:36:34 -0700 (Mon, 05 Oct 2020)
Log Message
Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'error.message')
https://bugs.webkit.org/show_bug.cgi?id=217232
<rdar://problem/69888156>
Patch by Federico Bucchi <fbuc...@apple.com> on 2020-10-05
Reviewed by Devin Rousso.
Add optional chaining for error to check its existence before using error.message
* UserInterface/Models/Resource.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (268015 => 268016)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-10-05 23:34:24 UTC (rev 268015)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-10-05 23:36:34 UTC (rev 268016)
@@ -1,3 +1,15 @@
+2020-10-05 Federico Bucchi <fbuc...@apple.com>
+
+ Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'error.message')
+ https://bugs.webkit.org/show_bug.cgi?id=217232
+ <rdar://problem/69888156>
+
+ Reviewed by Devin Rousso.
+
+ Add optional chaining for error to check its existence before using error.message
+
+ * UserInterface/Models/Resource.js:
+
2020-10-05 Devin Rousso <drou...@apple.com>
Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'breakpoint.disabled = true')
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js (268015 => 268016)
--- trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js 2020-10-05 23:34:24 UTC (rev 268015)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js 2020-10-05 23:36:34 UTC (rev 268016)
@@ -1196,14 +1196,14 @@
throw errorString;
}
-
+
// Private
-
+
_requestContentFailure(error)
{
return Promise.resolve({
error: WI.UIString("An error occurred trying to load the resource."),
- reason: error.message || this._failureReasonText,
+ reason: error?.message || this._failureReasonText,
sourceCode: this,
});
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
