Title: [268636] trunk
- Revision
- 268636
- Author
- wenson_hs...@apple.com
- Date
- 2020-10-16 21:55:32 -0700 (Fri, 16 Oct 2020)
Log Message
Add system trace points for flushing remote image buffers
https://bugs.webkit.org/show_bug.cgi?id=217853
Reviewed by Simon Fraser.
Source/WebKit:
Add trace points to capture drawing context flushes. This encapsulates time spent encoding display lists in
preparation for IPC.
* WebProcess/GPU/graphics/RemoteImageBufferMessageHandlerProxy.cpp:
(WebKit::RemoteImageBufferMessageHandlerProxy::flushDrawingContext):
(WebKit::RemoteImageBufferMessageHandlerProxy::flushDrawingContextAndWaitCommit):
Source/WTF:
See WebKit ChangeLog for more details.
* wtf/SystemTracing.h:
Tools:
See WebKit ChangeLog for more details.
* Tracing/SystemTracePoints.plist:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (268635 => 268636)
--- trunk/Source/WTF/ChangeLog 2020-10-17 04:39:53 UTC (rev 268635)
+++ trunk/Source/WTF/ChangeLog 2020-10-17 04:55:32 UTC (rev 268636)
@@ -1,3 +1,14 @@
+2020-10-16 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Add system trace points for flushing remote image buffers
+ https://bugs.webkit.org/show_bug.cgi?id=217853
+
+ Reviewed by Simon Fraser.
+
+ See WebKit ChangeLog for more details.
+
+ * wtf/SystemTracing.h:
+
2020-10-16 Jiewen Tan <jiewen_...@apple.com>
[WebAuthn] Add an experimental feature flag: WebAuthenticationModernEnabled
Modified: trunk/Source/WTF/wtf/SystemTracing.h (268635 => 268636)
--- trunk/Source/WTF/wtf/SystemTracing.h 2020-10-17 04:39:53 UTC (rev 268635)
+++ trunk/Source/WTF/wtf/SystemTracing.h 2020-10-17 04:55:32 UTC (rev 268636)
@@ -114,6 +114,8 @@
RenderingUpdateRunLoopObserverEnd,
LayerTreeFreezeStart,
LayerTreeFreezeEnd,
+ FlushRemoteImageBufferStart,
+ FlushRemoteImageBufferEnd,
UIProcessRange = 14000,
CommitLayerTreeStart,
Modified: trunk/Source/WebKit/ChangeLog (268635 => 268636)
--- trunk/Source/WebKit/ChangeLog 2020-10-17 04:39:53 UTC (rev 268635)
+++ trunk/Source/WebKit/ChangeLog 2020-10-17 04:55:32 UTC (rev 268636)
@@ -1,3 +1,17 @@
+2020-10-16 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Add system trace points for flushing remote image buffers
+ https://bugs.webkit.org/show_bug.cgi?id=217853
+
+ Reviewed by Simon Fraser.
+
+ Add trace points to capture drawing context flushes. This encapsulates time spent encoding display lists in
+ preparation for IPC.
+
+ * WebProcess/GPU/graphics/RemoteImageBufferMessageHandlerProxy.cpp:
+ (WebKit::RemoteImageBufferMessageHandlerProxy::flushDrawingContext):
+ (WebKit::RemoteImageBufferMessageHandlerProxy::flushDrawingContextAndWaitCommit):
+
2020-10-16 Devin Rousso <drou...@apple.com>
Web Inspector: rename `Highlight` so it doesn't conflict with CSS `Highlight`
Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferMessageHandlerProxy.cpp (268635 => 268636)
--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferMessageHandlerProxy.cpp 2020-10-17 04:39:53 UTC (rev 268635)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferMessageHandlerProxy.cpp 2020-10-17 04:55:32 UTC (rev 268636)
@@ -32,6 +32,7 @@
#include "RemoteRenderingBackendMessages.h"
#include "RemoteRenderingBackendProxy.h"
#include <WebCore/DisplayListItems.h>
+#include <wtf/SystemTracing.h>
namespace WebKit {
using namespace WebCore;
@@ -75,6 +76,7 @@
if (!m_remoteRenderingBackendProxy)
return;
+ TraceScope tracingScope(FlushRemoteImageBufferStart, FlushRemoteImageBufferEnd);
m_remoteRenderingBackendProxy->send(Messages::RemoteRenderingBackend::FlushImageBufferDrawingContext(displayList, m_remoteResourceIdentifier), m_remoteRenderingBackendProxy->renderingBackendIdentifier());
displayList.clear();
}
@@ -83,6 +85,8 @@
{
if (!m_remoteRenderingBackendProxy)
return;
+
+ TraceScope tracingScope(FlushRemoteImageBufferStart, FlushRemoteImageBufferEnd, 1);
m_sentFlushIdentifier = ImageBufferFlushIdentifier::generate();
m_remoteRenderingBackendProxy->send(Messages::RemoteRenderingBackend::FlushImageBufferDrawingContextAndCommit(displayList, m_sentFlushIdentifier, m_remoteResourceIdentifier), m_remoteRenderingBackendProxy->renderingBackendIdentifier());
displayList.clear();
Modified: trunk/Tools/ChangeLog (268635 => 268636)
--- trunk/Tools/ChangeLog 2020-10-17 04:39:53 UTC (rev 268635)
+++ trunk/Tools/ChangeLog 2020-10-17 04:55:32 UTC (rev 268636)
@@ -1,3 +1,14 @@
+2020-10-16 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Add system trace points for flushing remote image buffers
+ https://bugs.webkit.org/show_bug.cgi?id=217853
+
+ Reviewed by Simon Fraser.
+
+ See WebKit ChangeLog for more details.
+
+ * Tracing/SystemTracePoints.plist:
+
2020-10-16 Ryosuke Niwa <rn...@webkit.org>
IPC testing API should expose whether a given IPC message has sync reply or not
Modified: trunk/Tools/Tracing/SystemTracePoints.plist (268635 => 268636)
--- trunk/Tools/Tracing/SystemTracePoints.plist 2020-10-17 04:39:53 UTC (rev 268635)
+++ trunk/Tools/Tracing/SystemTracePoints.plist 2020-10-17 04:55:32 UTC (rev 268636)
@@ -459,6 +459,18 @@
</dict>
<dict>
<key>Name</key>
+ <string>Flush remote image buffer</string>
+ <key>Type</key>
+ <string>Interval</string>
+ <key>Component</key>
+ <string>47</string>
+ <key>CodeBegin</key>
+ <string>12015</string>
+ <key>CodeEnd</key>
+ <string>12016</string>
+ </dict>
+ <dict>
+ <key>Name</key>
<string>Commit RemoteLayerTree transaction</string>
<key>Type</key>
<string>Interval</string>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
